-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icinga Kubernetes
#40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
805e936
to
87d357f
Compare
mocdaniel
requested changes
Feb 27, 2024
ac35f7c
to
c2505d6
Compare
c2505d6
to
0bc8cc7
Compare
This is required to have `Icinga Kubernetes Web` and a recent version of `Icinga Director`.
Although the `Icinga Web` image tags are coupled to release tags, several modules are included. We rebuild the image using the same latest release tag when modules get new release, so the image needs to be pulled again in such cases. Updates to the base image (OS) are also pushed using the same tags. This does not only apply to this image, so the pull policy for all other images should also be reconsidered.
This chart provides common template helpers.
0bc8cc7
to
ea4a774
Compare
Note that the chart is subject to change as `Icinga Kubernetes` is not yet released, especially regarding the configuration. At the moment, a configuration file is mounted from a `ConfigMap` that does not support secrets, as `Icinga Kubernetes` lacks support for environment variables. This will change in the near future.
85fc972
to
084ce0c
Compare
084ce0c
to
8f16dfa
Compare
mocdaniel
previously approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for your contribution, LGTM!
The merge-base changed after approval.
mocdaniel
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR depends on #41. Make sure to merge that one first. Commits from that PR are also included here to ease testing.
This PR adds a chart for deploying
Icinga Kubernetes and
Icinga Kubernetes Web.
Note that the chart is subject to change as
Icinga Kubernetes
is notyet released, especially regarding the configuration. At the moment, a
configuration file is mounted from a
ConfigMap
that does not supportsecrets, as
Icinga Kubernetes
lacks support for environment variables.This will change in the near future.
I also chose to depend on the
Bitnami Common Library Chart
as itprovides nice common template helpers which we just copy around
at the moment.