Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icinga Kubernetes #40

Merged
merged 14 commits into from
Feb 27, 2024
Merged

Add Icinga Kubernetes #40

merged 14 commits into from
Feb 27, 2024

Conversation

lippserd
Copy link
Member

@lippserd lippserd commented Feb 23, 2024

NOTE: This PR depends on #41. Make sure to merge that one first. Commits from that PR are also included here to ease testing.

This PR adds a chart for deploying
Icinga Kubernetes and
Icinga Kubernetes Web.

Note that the chart is subject to change as Icinga Kubernetes is not
yet released, especially regarding the configuration. At the moment, a
configuration file is mounted from a ConfigMap that does not support
secrets, as Icinga Kubernetes lacks support for environment variables.
This will change in the near future.

I also chose to depend on the Bitnami Common Library Chart as it
provides nice common template helpers which we just copy around
at the moment.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Feb 23, 2024
@lippserd lippserd force-pushed the add-icinga-kuberentes branch 3 times, most recently from 805e936 to 87d357f Compare February 23, 2024 09:57
@mocdaniel mocdaniel force-pushed the add-icinga-kuberentes branch from ac35f7c to c2505d6 Compare February 27, 2024 07:34
@lippserd lippserd force-pushed the add-icinga-kuberentes branch from c2505d6 to 0bc8cc7 Compare February 27, 2024 08:27
This is required to have `Icinga Kubernetes Web` and a recent version of
`Icinga Director`.
Although the `Icinga Web` image tags are coupled to release tags,
several modules are included. We rebuild the image using the same latest
release tag when modules get new release, so the image needs to be
pulled again in such cases. Updates to the base image (OS) are also
pushed using the same tags. This does not only apply to this image, so
the pull policy for all other images should also be reconsidered.
This chart provides common template helpers.
@lippserd lippserd force-pushed the add-icinga-kuberentes branch from 0bc8cc7 to ea4a774 Compare February 27, 2024 08:32
@lippserd lippserd marked this pull request as ready for review February 27, 2024 08:35
@lippserd lippserd requested a review from mocdaniel February 27, 2024 08:35
lippserd and others added 5 commits February 27, 2024 10:19
Note that the chart is subject to change as `Icinga Kubernetes` is not
yet released, especially regarding the configuration. At the moment, a
configuration file is mounted from a `ConfigMap` that does not support
secrets, as `Icinga Kubernetes` lacks support for environment variables.
This will change in the near future.
@lippserd lippserd force-pushed the add-icinga-kuberentes branch 2 times, most recently from 85fc972 to 084ce0c Compare February 27, 2024 09:27
@lippserd lippserd force-pushed the add-icinga-kuberentes branch from 084ce0c to 8f16dfa Compare February 27, 2024 09:30
mocdaniel
mocdaniel previously approved these changes Feb 27, 2024
Copy link
Collaborator

@mocdaniel mocdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your contribution, LGTM!

@lippserd lippserd dismissed mocdaniel’s stale review February 27, 2024 13:37

The merge-base changed after approval.

@mocdaniel mocdaniel self-requested a review February 27, 2024 13:38
@mocdaniel mocdaniel merged commit 99d265c into main Feb 27, 2024
3 checks passed
@mocdaniel mocdaniel deleted the add-icinga-kuberentes branch February 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants