Restore 'Connection: close' behaviour in HTTP responses

Actually the `corked` functionality caused problems with not closing connections properly. Full Analysis: #6799 (comment) Full credits to @swegener :) fixes #6799
Icinga · Dec 5, 2018 · 080f666 · 080f666
1 parent 18de1f7
commit 080f666
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/lib/remote/httpresponse.cpp b/lib/remote/httpresponse.cpp
@@ -111,6 +111,9 @@ void HttpResponse::Finish()
 	}
 
 	m_State = HttpResponseEnd;
+
+	if (m_Request->ProtocolVersion == HttpVersion10 || m_Request->Headers->Get("connection") == "close")
+		m_Stream->Shutdown();
 }
 
 bool HttpResponse::Parse(StreamReadContext& src, bool may_wait)

diff --git a/lib/remote/httpserverconnection.cpp b/lib/remote/httpserverconnection.cpp
@@ -362,13 +362,6 @@ void HttpServerConnection::DataAvailableHandler()
 
 			close = true;
 		}
-
-		/* Request finished, decide whether to explicitly close the connection. */
-		if (m_CurrentRequest.ProtocolVersion == HttpVersion10 ||
-			m_CurrentRequest.Headers->Get("connection") == "close") {
-			m_Stream->Shutdown();
-			close = true;
-		}
 	} else
 		close = true;