Skip to content

Commit

Permalink
Remove redundant call to Serialize() in ConfigItem::Commit()
Browse files Browse the repository at this point in the history
The very same object is already serialized a few lines above, the result is
even stored in a variable, but that variable was not used before. Simply using
this variable results in a noticeable improvement of config validation times.
  • Loading branch information
julianbrost committed Apr 28, 2022
1 parent a51c004 commit 2dcdae4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/config/configitem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ ConfigObject::Ptr ConfigItem::Commit(bool discard)
Dictionary::Ptr persistentItem = new Dictionary({
{ "type", type->GetName() },
{ "name", GetName() },
{ "properties", Serialize(dobj, FAConfig) },
{ "properties", serializedObject },
{ "debug_hints", dhint },
{ "debug_info", new Array({
m_DebugInfo.Path,
Expand Down

0 comments on commit 2dcdae4

Please sign in to comment.