IfwApiCheckTask: Process final cr in the global thread pool

Icinga · Aug 30, 2024 · a88f2e1 · a88f2e1
1 parent 4bf7422
commit a88f2e1
Showing 1 changed file with 35 additions and 52 deletions.
diff --git a/lib/methods/ifwapichecktask.cpp b/lib/methods/ifwapichecktask.cpp
@@ -86,16 +86,6 @@ static reportIfwResultFunc getReportIfwResultFunc(const Checkable::Ptr checkable
 	};
 }
 
-static void ReportIfwCheckResult(
-	boost::asio::yield_context yc,const Value& cmdLine, const String& output, double start, const reportIfwResultFunc& processFinishedHandler
-)
-{
-	double end = Utility::GetTime();
-	CpuBoundWork cbw (yc);
-
-	processFinishedHandler(cmdLine, output, start, end, 3, nullptr);
-}
-
 static const char* GetUnderstandableError(const std::exception& ex)
 {
 	auto se (dynamic_cast<const boost::system::system_error*>(&ex));
@@ -115,16 +105,23 @@ static void DoIfwNetIo(
 {
 	namespace http = boost::beast::http;
 
+	auto asyncReportResult = [start, cmdLine, processFinishedHandler](
+		const String& output, double end, int exitcode = 3, const Array::Ptr& perfdata = nullptr
+	) {
+		Utility::QueueAsyncCallback([output, start, end, exitcode, perfdata, processFinishedHandler, cmdLine]() {
+			processFinishedHandler(cmdLine, output, start, end, exitcode, perfdata);
+		});
+	};
+
 	boost::beast::flat_buffer buf;
 	http::response<http::string_body> resp;
 
 	try {
 		Connect(conn.lowest_layer(), psHost, psPort, yc);
 	} catch (const std::exception& ex) {
-		ReportIfwCheckResult(
-			yc, cmdLine,
+		asyncReportResult(
 			"Can't connect to IfW API on host '" + psHost + "' port '" + psPort + "': " + GetUnderstandableError(ex),
-			start, processFinishedHandler
+			Utility::GetTime()
 		);
 		return;
 	}
@@ -134,11 +131,9 @@ static void DoIfwNetIo(
 	try {
 		sslConn.async_handshake(conn.next_layer().client, yc);
 	} catch (const std::exception& ex) {
-		ReportIfwCheckResult(
-			yc, cmdLine,
-			"TLS handshake with IfW API on host '" + psHost + "' (SNI: '" + san
-				+ "') port '" + psPort + "' failed: " + GetUnderstandableError(ex),
-			start, processFinishedHandler
+		asyncReportResult(
+			"TLS handshake with IfW API on host '" + psHost + "' (SNI: '" + san+ "') port '" + psPort + "' failed: " + GetUnderstandableError(ex),
+			Utility::GetTime()
 		);
 		return;
 	}
@@ -152,11 +147,10 @@ static void DoIfwNetIo(
 		} catch (const std::exception&) {
 		}
 
-		ReportIfwCheckResult(
-			yc, cmdLine,
+		asyncReportResult(
 			"Certificate validation failed for IfW API on host '" + psHost + "' (SNI: '" + san + "'; CN: "
 				+ (cn.IsString() ? "'" + cn + "'" : "N/A") + ") port '" + psPort + "': " + sslConn.GetVerifyError(),
-			start, processFinishedHandler
+			Utility::GetTime()
 		);
 		return;
 	}
@@ -165,21 +159,19 @@ static void DoIfwNetIo(
 		http::async_write(conn, req, yc);
 		conn.async_flush(yc);
 	} catch (const std::exception& ex) {
-		ReportIfwCheckResult(
-			yc, cmdLine,
+		asyncReportResult(
 			"Can't send HTTP request to IfW API on host '" + psHost + "' port '" + psPort + "': " + GetUnderstandableError(ex),
-			start, processFinishedHandler
+			Utility::GetTime()
 		);
 		return;
 	}
 
 	try {
 		http::async_read(conn, buf, resp, yc);
 	} catch (const std::exception& ex) {
-		ReportIfwCheckResult(
-			yc, cmdLine,
+		asyncReportResult(
 			"Can't read HTTP response from IfW API on host '" + psHost + "' port '" + psPort + "': " + GetUnderstandableError(ex),
-			start, processFinishedHandler
+			Utility::GetTime()
 		);
 		return;
 	}
@@ -191,44 +183,39 @@ static void DoIfwNetIo(
 		sslConn.async_shutdown(yc[ec]);
 	}
 
-	CpuBoundWork cbw (yc);
 	Value jsonRoot;
 
 	try {
 		jsonRoot = JsonDecode(resp.body());
 	} catch (const std::exception& ex) {
-		processFinishedHandler(
-			cmdLine,"Got bad JSON from IfW API on host '" + psHost + "' port '" + psPort + "': " + ex.what(), start, end, 3, nullptr);
+		asyncReportResult("Got bad JSON from IfW API on host '" + psHost + "' port '" + psPort + "': " + ex.what(), end);
 		return;
 	}
 
 	if (!jsonRoot.IsObjectType<Dictionary>()) {
-		processFinishedHandler(
-			cmdLine,
+		asyncReportResult(
 			"Got JSON, but not an object, from IfW API on host '"+ psHost + "' port '" + psPort + "': " + JsonEncode(jsonRoot),
-			start, end, 3, nullptr
+			end
 		);
 		return;
 	}
 
 	Value jsonBranch;
 
 	if (!Dictionary::Ptr(jsonRoot)->Get(psCommand, &jsonBranch)) {
-		processFinishedHandler(
-			cmdLine,
+		asyncReportResult(
 			"Missing ." + psCommand + " in JSON object from IfW API on host '"
 				+ psHost + "' port '" + psPort + "': " + JsonEncode(jsonRoot),
-			start, end, 3, nullptr
+			end
 		);
 		return;
 	}
 
 	if (!jsonBranch.IsObjectType<Dictionary>()) {
-		processFinishedHandler(
-			cmdLine,
+		asyncReportResult(
 			"." + psCommand + " in JSON from IfW API on host '"
 				+ psHost + "' port '" + psPort + "' is not an object: " + JsonEncode(jsonBranch),
-			start, end, 3, nullptr
+			end
 		);
 		return;
 	}
@@ -238,11 +225,10 @@ static void DoIfwNetIo(
 	Value exitcode;
 
 	if (!result->Get("exitcode", &exitcode)) {
-		processFinishedHandler(
-			cmdLine,
+		asyncReportResult(
 			"Missing ." + psCommand + ".exitcode in JSON object from IfW API on host '"
 				+ psHost + "' port '" + psPort + "': " + JsonEncode(result),
-			start, end, 3, nullptr
+			end
 		);
 		return;
 	}
@@ -251,11 +237,10 @@ static void DoIfwNetIo(
 	static const auto exitcodeList (Array::FromSet(exitcodes)->Join(", "));
 
 	if (!exitcode.IsNumber() || exitcodes.find(exitcode) == exitcodes.end()) {
-		processFinishedHandler(
-			cmdLine,
+		asyncReportResult(
 			"Got bad exitcode " + JsonEncode(exitcode) + " from IfW API on host '" + psHost + "' port '" + psPort
 				+ "', expected one of: " + exitcodeList,
-			start, end, 3, nullptr
+			end
 		);
 		return;
 	}
@@ -266,11 +251,10 @@ static void DoIfwNetIo(
 	try {
 		perfdata = perfdataVal;
 	} catch (const std::exception&) {
-		processFinishedHandler(
-			cmdLine,
+		asyncReportResult(
 			"Got bad perfdata " + JsonEncode(perfdataVal) + " from IfW API on host '"
 				+ psHost + "' port '" + psPort + "', expected an array",
-			start, end, 3, nullptr
+			end
 		);
 		return;
 	}
@@ -280,18 +264,17 @@ static void DoIfwNetIo(
 
 		for (auto& pv : perfdata) {
 			if (!pv.IsString()) {
-				processFinishedHandler(
-					cmdLine,
+				asyncReportResult(
 					"Got bad perfdata value " + JsonEncode(perfdata) + " from IfW API on host '"
 						+ psHost + "' port '" + psPort + "', expected an array of strings",
-					start, end, 3, nullptr
+					end
 				);
 				return;
 			}
 		}
 	}
 
-	processFinishedHandler(cmdLine, result->Get("checkresult"), start, end, exitcode, perfdata);
+	asyncReportResult(result->Get("checkresult"), end, exitcode, perfdata);
 }
 
 void IfwApiCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckResult::Ptr& cr,