Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make notification mails more readable. Remove redundancy and cruft. #5468

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Make notification mails more readable. Remove redundancy and cruft. #5468

merged 1 commit into from
Aug 14, 2017

Conversation

cycloon
Copy link
Contributor

@cycloon cycloon commented Aug 7, 2017

I tried to make Icinga's notification mails more readable, especially on mobile devices. Would be glad, if you could incorporate the changes:

  • remove the Icinga 2 name.
  • remove cruft around the primary status message
  • do not precede URL with anything, it speaks for itself
  • remove display names from table, as they are also in the subject and in the primary status message

@dnsmichi
Copy link
Contributor

dnsmichi commented Aug 7, 2017 •
edited
Loading

Thanks. Opinions on layout and design always differ, and therefore these scripts are located in /etc/icinga2/scripts where users can modify them. Package updates won't override local user changes.

Imho we should leave the notification scripts as is for now. Waiting for others to comment.

@dnsmichi dnsmichi added needs feedback We'll only proceed once we hear from you again area/notifications Notification events labels Aug 7, 2017
@dnsmichi dnsmichi self-requested a review August 10, 2017 08:48
@dnsmichi
Copy link
Contributor

Been thinking about it for a while. Since we probably need to incorporate more changes for making HOSTADDRESS optional in #5474 it would be worthwhile to remove redundant details. Thanks for the pointer, I'll review the changes.

@dnsmichi dnsmichi added this to the 2.7.1 milestone Aug 11, 2017
@dnsmichi dnsmichi added enhancement New feature or request and removed needs feedback We'll only proceed once we hear from you again labels Aug 14, 2017
@dnsmichi
Copy link
Contributor

Short note for future PRs: Please use a specific branch in your forked repository to commit changes for PRs. I will force push your master remotely via this PR now.

dnsmichi
dnsmichi approved these changes Aug 14, 2017
View reviewed changes
Copy link
Contributor

@dnsmichi dnsmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@dnsmichi dnsmichi merged commit c3ecc96 into Icinga:master Aug 14, 2017
dnsmichi pushed a commit that referenced this pull request Aug 14, 2017
Notification scripts: More readable & redundancy cleanup
7b9634e 
refs #5468
@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Aug 14, 2017
@dnsmichi
Copy link
Contributor

https://www.icinga.com/2017/08/23/advisory-for-icinga-2-v2-7-update-and-mail-notification-scripts/

@cycloon
Copy link
Contributor Author

cycloon commented Sep 26, 2017

Oh I missed this. Great, and thank you for reconsidering.

@Al2Klimov Al2Klimov mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
area/notifications Notification events backported Fix was included in a bugfix release enhancement New feature or request
Projects
None yet
Milestone
2.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cycloon @dnsmichi