Add systemd watchdog and adjust reload behaviour #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Crunsher: Nice work, have you also thought about send a status to systemd like mod_systemd for httpd does? Having some of the internal performance data or states like config dump to database done in a status line could be a nice feature. |
|
Not for this one, please create a new issue for additional status messages. The big change with this PR is the change to how we handle our reload (so the watchdog does not starve) |
Crunsher
force-pushed
the
feature/watchdog-2287
branch
from
152b688 to
7f0a66a
Compare
Crunsher
force-pushed
the
feature/watchdog-2287
branch
from
7f0a66a to
c418a96
Compare
gunnarbeutner
approved these changes
Jan 21, 2018
|
LGTM. 👍 |
This was referenced Feb 22, 2018
dnsmichi
pushed a commit
that referenced
this pull request
May 3, 2019
This follows the same principle as with the shutdown handler, and was introduced with the changed reload handling with 2.9. Previously IsShuttingDown() was sufficient which got set at one location. SigUsr2 as handler introduced a new location where m_ShuttingDown is not necessarily set yet. Since this handler gets called when l_Restarting is enabled, we'll use this flag to avoid config update events resulting in object deactivation (object->IsActive() always returns false). refs #5996 refs #6691 refs #6970 fixes #7125
dnsmichi
pushed a commit
that referenced
this pull request
May 16, 2019
This follows the same principle as with the shutdown handler, and was introduced with the changed reload handling with 2.9. Previously IsShuttingDown() was sufficient which got set at one location. SigUsr2 as handler introduced a new location where m_ShuttingDown is not necessarily set yet. Since this handler gets called when l_Restarting is enabled, we'll use this flag to avoid config update events resulting in object deactivation (object->IsActive() always returns false). refs #5996 refs #6691 refs #6970 fixes #7125 (cherry picked from commit 78e24c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: