-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TLS support for the GelfWriter feature #6813
Conversation
Cool, thanks. @marcofl owes you a Gin ;-) |
Verify that #6989 does not affect this too. |
Verify that this works with Graylog 3. |
Should use Boost ASIO, blocked by #7010. |
Similar code is located in the InfluxDBWriter class in git master, but only for the TLS stream parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boost Asio similar to the other features, the TlsStream class is subject for removal before 2.11 is being released.
This implements TLS support for the GelfWriter.
This adds the documentation for the GelfWriter TLS support.
9418b5a
to
bc0ab93
Compare
I updated the PR to use Boost Asio for TLS as well as for non TLS connections. I tested this against the Graylog vagrant box from icinga-vagrant (as described above). I still need to test against Graylog 3, once done I'll provide a full test log. |
Cool, thank you :-) |
I'm rewriting other parts in the core right now, let's just stick with the final implemention here and if Graylog 3 doesn't work, we'll fix it later. Same goes for ES7 in another ticket. I need these changes in my branch ;) Thanks for your work 👍 |
This implements TLS support for the GelfWriter feature.
Test
I used the Icinga 2 Vagrant box with Graylog from icinga-vagrant. But I only used the Graylog instance from there, the Icinga 2 daemon ran directly on my notebook computer.
Create CA
Generate certificate for Graylog (server)
Generate certificate for Icinga 2 (client)
I copied
ca.crt
,icinga2-client.key
andicinga2-client.crt
to my machine, since the Icinga 2 daemon runs there.Create new Gelf Input with TLS
Activate and configure GelfWriter feature
Verifying TLS usage
Start the Icinga 2 daemon, verify that the GelfWriter actually writes data.
Check Graylog.
Graylog receives data.
Verify encryption.
(192.168.33.6 is the ip address of the Graylog VM).
fixes #6152