Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpServerConnection#DataAvailableHandler(): reduce log spam #6877

Merged
merged 1 commit into from
Jan 7, 2019
Merged

HttpServerConnection#DataAvailableHandler(): reduce log spam #6877

merged 1 commit into from
Jan 7, 2019

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov requested a review from lippserd January 7, 2019 14:33
@lippserd lippserd requested a review from dnsmichi January 7, 2019 14:44
@lippserd
Copy link
Member

lippserd commented Jan 7, 2019

@dnsmichi The new log line shows that HttpServerConnection#DataAvailableHandler() is always called multiple times. Every API request produces such a log line. We introduced this fix to prevent dead locks. This PR reduces the log message's severity so that it is only visible in debug logs. Though we should of course fix that this method is called multiple times.

@dnsmichi
Copy link
Contributor

dnsmichi commented Jan 7, 2019

We were about to change this in December, IIRC. I'm fine with reducing the log messages here, the typical user cannot do anything about this debug info anyways. Thanks 👍

@dnsmichi dnsmichi added this to the 2.11.0 milestone Jan 7, 2019
@dnsmichi dnsmichi added area/api REST API area/log Logging related labels Jan 7, 2019
@dnsmichi dnsmichi merged commit 2e1b6bd into master Jan 7, 2019
@Al2Klimov Al2Klimov deleted the bugfix/http-log-spam branch January 7, 2019 14:49
@dnsmichi dnsmichi added the bug Something isn't working label Mar 28, 2019
@dnsmichi dnsmichi modified the milestones: 2.11.0, 2.10.5 Mar 28, 2019
@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Mar 28, 2019
@dnsmichi dnsmichi modified the milestones: 2.10.5, 2.11.0 Apr 26, 2019
@dnsmichi dnsmichi modified the milestones: 2.11.0, 2.10.5 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd lippserd approved these changes

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
area/api REST API area/log Logging related backported Fix was included in a bugfix release bug Something isn't working
Projects
None yet
Milestone
2.10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Al2Klimov @lippserd @dnsmichi