Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base_value/format test easier to understand #8815

Merged

Conversation

julianbrost
Copy link
Contributor

The old test looked really strange where it reads 3 into a Value and then checks that it's not 3. However, what's going on there is that operator>> for Value actually always reads a String, so instead check for what v should be, not what it should not be.

The old test looked really strange where it reads 3 into a Value and then
checks that it's not 3. However, what's going on there is that operator>> for
Value actually always reads a String, so instead check for what v should be,
not what it should not be.
@julianbrost julianbrost added area/tests Unit and environment tests core/quality Improve code, libraries, algorithms, inline docs labels May 31, 2021
@julianbrost julianbrost requested a review from Al2Klimov May 31, 2021 15:32
@icinga-probot icinga-probot bot added this to the 2.14.0 milestone May 31, 2021
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Al2Klimov Al2Klimov merged commit 02db80d into master Aug 3, 2021
@icinga-probot icinga-probot bot deleted the feature/make-base-value-format-test-easier-to-understand branch August 3, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit and environment tests core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants