Fix typo #8895
Merged
Fix typo #8895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icinga-probot
bot
added
area/distributed
|
@cla-bot check |
julianbrost
requested changes
Oct 7, 2021
lib/remote/apilistener.cpp
Outdated
| @@ -660,7 +660,7 @@ void ApiListener::NewClientHandlerInternal( | |||
| identity = GetCertificateCN(cert); | |||
| } catch (const std::exception&) { | |||
| Log(LogCritical, "ApiListener") | |||
| << "Cannot get certificate common name from cert path: '" << GetDefaultCertPath() << "'."; | |||
| << "Cannot get certificate common name from peer cert."; | |||
There was a problem hiding this comment.
The message would be more helpful if it included the peer address (should already be available in the variable conninfo)
Al2Klimov
force-pushed
the
bugfix/typo-8766
branch
from
4b774d8 to
8b1e6ae
Compare
Al2Klimov
force-pushed
the
bugfix/typo-8766
branch
from
8b1e6ae to
3bf180a
Compare
julianbrost
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8766