-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITL: add all businessprocess module check parameters #9103
Conversation
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @log1-c
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @log1-c
|
@cla-bot check |
Note: must be merged with squash-and-merge. |
naming of the defined variables should be consistent with the ones already in use, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
While you're on it, undo the alphabetical sorting of already not alphabetically sorted params.
changes done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also reorder argument state-type
after the root-cause
arg, shall be sorted alphabetically :) and update the documentation accordingly.
one doesn't want alphabetical sorting, the other does, not sure what is correct now, but here you go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't see it, that @Al2Klimov change requested you not to do that! But looks fine to me now.
ITL: add all businessprocess module check parameters
closes #9110
closes #9107
resolves #9103