Windows: explicitly flush state file #9446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icinga-probot
bot
added
area/windows
julianbrost
force-pushed
the
bugfix/windows-flush-state-file
branch
from
c1cf7f3 to
6226c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress for testing if using a second handle for the same file is good enough for flushing previous writes to that file done using another handle (i.e. does it flush everything pending on that handle or that file). If not, we have to replace the
std::fstreamwith something else that allows control over the underlying file handle.Also includes another commit to actually get more useful errors if something goes wrong.
refs #8840