-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Option to disable RetryWrites to CheckCommand of mongodb #9539
Add the Option to disable RetryWrites to CheckCommand of mongodb #9539
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
|
1 similar comment
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
|
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
|
The CLA comparision don`t work for my Github-Account. |
Hello Markus and thank you for contributing! First of all please get rid of the merge commit. Then we'll see how you can rebase the result. Best, |
I've no Idea how to do that. |
Shall I fix it for you? |
That would be nice. I only want to add the Config-Option from the Upstream-Project so that other User can use it as well as they need that for newer MongoDB. |
At the moment the tree looks like this:
But git diff 99efdea ea991db says those two commits don’t differ. So only one is needed. 99efdea looks better on GitHub, so I'll take just this one... |
ff407ed
to
99efdea
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
|
Now you should (only if you're the author of all commits!):
|
99efdea
to
ed0166b
Compare
Having an eMail-Address in the Github-Account and using a signed Commit was not enough for the cla-bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the documentation?
TODO (on our side) while mergingsquash |
This adds the Option to disable Retry Writes to the CheckCommand definition for mongodb.
This fixes a Problem in check_mongodb.py with newer MongoDB-Versions.
mzupan/nagios-plugin-mongodb@0377f5d