Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Option to disable RetryWrites to CheckCommand of mongodb #9539

Merged

Conversation

atwebm
Copy link
Contributor

@atwebm atwebm commented Oct 15, 2022

This adds the Option to disable Retry Writes to the CheckCommand definition for mongodb.
This fixes a Problem in check_mongodb.py with newer MongoDB-Versions.
mzupan/nagios-plugin-mongodb@0377f5d

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Oct 15, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@atwebm
Copy link
Contributor Author

atwebm commented Oct 29, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Oct 29, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@atwebm
Copy link
Contributor Author

atwebm commented Nov 8, 2022

The CLA comparision don`t work for my Github-Account.
But this is only a Configuration-Option from the Upstream Check Script. Nothing of any Invention.

@Al2Klimov
Copy link
Member

Hello Markus and thank you for contributing!

First of all please get rid of the merge commit. Then we'll see how you can rebase the result.

Best,
A/K

@atwebm
Copy link
Contributor Author

atwebm commented Nov 22, 2022

I've no Idea how to do that.
My main profession is Server-Infrastructure but not so much Dev.

@Al2Klimov
Copy link
Member

Shall I fix it for you?

@atwebm
Copy link
Contributor Author

atwebm commented Nov 23, 2022

That would be nice.

I only want to add the Config-Option from the Upstream-Project so that other User can use it as well as they need that for newer MongoDB.

@Al2Klimov
Copy link
Member

At the moment the tree looks like this:

*   ff407ed7d (HEAD, origin/pull/9539) Merge branch 'feature/itl-check-mongodb-retrywrites' of github.com:atwebm/icinga2 into feature/itl-check-mongodb-retrywrites
|\
| * ea991db84 Add the Option to disable RetryWrites to CheckCommand for newer check_mongodb.py
* | 99efdea8d Add the Option to disable RetryWrites to CheckCommand for newer check_mongodb.py
|/
*   dd7009dc6 (BASE) Merge pull request #9406 from Icinga/bugfix/handle-ignore-on-error-uses-cases-properly

But git diff 99efdea ea991db says those two commits don’t differ. So only one is needed. 99efdea looks better on GitHub, so I'll take just this one...

@Al2Klimov Al2Klimov force-pushed the feature/itl-check-mongodb-retrywrites branch from ff407ed to 99efdea Compare November 23, 2022 10:05
@cla-bot
Copy link

cla-bot bot commented Nov 23, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Markus Weber.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Al2Klimov
Copy link
Member

Now you should (only if you're the author of all commits!):

  • git checkout feature/itl-check-mongodb-retrywrites
  • git reset --hard 99efdea
  • git commit --amend --no-edit --reset-author
  • git push -f

@atwebm atwebm force-pushed the feature/itl-check-mongodb-retrywrites branch from 99efdea to ed0166b Compare November 23, 2022 10:23
@cla-bot cla-bot bot added the cla/signed label Nov 23, 2022
@atwebm
Copy link
Contributor Author

atwebm commented Nov 23, 2022

Having an eMail-Address in the Github-Account and using a signed Commit was not enough for the cla-bot.
The Adding of an eMAil-Address to a Repo needs a new Commit.
This is the Reason, why there were two commits before.
With your help, I could striped this down to one commit.

Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the documentation?

@Al2Klimov Al2Klimov self-requested a review January 27, 2023 10:06
@Al2Klimov
Copy link
Member

TODO (on our side) while merging

squash

@Al2Klimov Al2Klimov added this to the 2.14.0 milestone Jan 27, 2023
@Al2Klimov Al2Klimov added the area/itl Template Library CheckCommands label Jan 27, 2023
@Al2Klimov Al2Klimov requested a review from julianbrost January 27, 2023 11:09
@julianbrost julianbrost enabled auto-merge (squash) January 27, 2023 14:12
@julianbrost julianbrost merged commit 0bdcd08 into Icinga:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/itl Template Library CheckCommands cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants