Separately handle apply rules targetting only specific parent objects

[Al2Klimov]

not to unnecessarily run e.g. the filter assign where host.name=="example.com" for all hosts being not example.com.

ref/IP/42584
(PR 3/3)

Blocked by

• Lookup apply rules faster by Type*, not String and by map instead of ==/!= #9543 (I'll benchmark everything together anyway)

[Al2Klimov]

Before/After time icinga2 daemon -C

real 51m52.482s
user 231m26.251s
sys 114m36.421s

real 33m59.397s
user 182m42.875s
sys 53m9.410s

😎

[Al2Klimov]

Julian, shall I

1. don't evaluate the filter for the targeted ones as they're already known or
2. extend the filter tree scan algo a bit so that it also outsmarts host.name == "x" && vars.but_only_with_y

?

[Al2Klimov]

I prefer 1.

[julianbrost]

Please provide a list of all kinds of expressions this PR can optimize.

[Al2Klimov]

PING #9545 (comment)

[julianbrost]

Julian, shall I

1. don't evaluate the filter for the targeted ones as they're already known or
2. extend the filter tree scan algo a bit so that it also outsmarts host.name == "x" && vars.but_only_with_y
   ?

Well if evaluating the filter expression is not needed, why do it.

Something like host.name == "x" && vars.but_only_with_y does not sound like a very common example, if you already know the host, why restrict it further. However, something like apply Notification "..." to Service { assign where service.name == "..." && host.vars.env == "production" } sounds more useful to me.

But to discuss this in detail, this would be helpful:

Please provide a list of all kinds of expressions this PR can optimize.

[julianbrost]

Please also add documentation comments to the other functions in applyrule-targeted.cpp, this should make it way easier to follow that file.

[julianbrost]

Regarding the use of inline: I'm not sure why you're adding that keyword explicitly. As the functions are defined inside class definitions, they are inline implicitly (https://en.cppreference.com/w/cpp/language/inline).

[Al2Klimov]

IMAO explicit is more expressive than implicit.

[julianbrost]

The GH Actions want your attention.

[yhabteab]

The GH Actions want your attention.

Forgot to also commit the changes in the header file 🙈

[julianbrost]

I don't understand the point of your last push, is there anything new that this fixes?

[julianbrost]

Test config that hopefully covers most edge cases

object CheckCommand "dummy" { command = ["true"] }
object NotificationCommand "dummy" { command = ["true"] }
object Host "h" { check_command = "dummy" }
object User "u" {}

// ApplyRule::RegisterType("Service", { "Host" });

apply Service "s" {
    log("applying Service " + name + " to Host " + host.name)
    check_command = "dummy"
    assign where host.name == "h"
    assign where host.name == "h"
}

apply Service "s-warn" {
    log("applying Service " + name + " to Host " + host.name)
    check_command = "dummy"
    assign where host.name == "404"
    assign where host.name == "404"
}

apply Service "s-true" to Host {
    log("applying Service " + name + " to Host " + host.name)
    check_command = "dummy"
    assign where true
}

apply Service "s-false" to Host {
    log("applying Service " + name + " to Host " + host.name)
    check_command = "dummy"
    assign where false
}

// ApplyRule::RegisterType("Dependency", { "Host", "Service" });

apply Dependency "dep-host" to Host {
    log("applying Dependency " + name + " to Host " + host.name)
    parent_host_name = "h"
    assign where host.name == "h"
    assign where host.name == "h"
}

apply Dependency "dep-host-warn" to Host {
    log("applying Dependency " + name + " to Host " + host.name)
    parent_host_name = "h"
    assign where host.name == "404"
    assign where host.name == "404"
}

apply Dependency "dep-host-true" to Host {
    log("applying Dependency " + name + " to Host " + host.name)
    parent_host_name = "h"
    assign where true
}

apply Dependency "dep-host-false" to Host {
    log("applying Dependency " + name + " to Host " + host.name)
    parent_host_name = "h"
    assign where false
}

apply Dependency "dep-service" to Service {
    log("applying Dependency " + name + " to Service " + host.name + "!" + service.name)
    parent_host_name = "h"
    assign where host.name == "h" && service.name == "s"
    assign where host.name == "h" && service.name == "s"
}

apply Dependency "dep-service-warn" to Service {
    log("applying Dependency " + name + " to Service " + host.name + "!" + service.name)
    parent_host_name = "h"
    assign where host.name == "404" && service.name == "s"
    assign where host.name == "404" && service.name == "s"
}

apply Dependency "dep-service-true" to Service {
    log("applying Dependency " + name + " to Service " + host.name + "!" + service.name)
    parent_host_name = "h"
    assign where true
}

apply Dependency "dep-service-false" to Service {
    log("applying Dependency " + name + " to Service " + host.name + "!" + service.name)
    parent_host_name = "h"
    assign where false
}

// ApplyRule::RegisterType("Notification", { "Host", "Service" });

apply Notification "notify-host" to Host {
    log("applying Notification " + name + " to Host " + host.name)
    command = "dummy"
    users = ["u"]
    assign where host.name == "h"
    assign where host.name == "h"
}

apply Notification "notify-host-warn" to Host {
    log("applying Notification " + name + " to Host " + host.name)
    command = "dummy"
    users = ["u"]
    assign where host.name == "404"
    assign where host.name == "404"
}

apply Notification "notify-host-true" to Host {
    log("applying Notification " + name + " to Host " + host.name)
    command = "dummy"
    users = ["u"]
    assign where true
}

apply Notification "notify-host-false" to Host {
    log("applying Notification " + name + " to Host " + host.name)
    command = "dummy"
    users = ["u"]
    assign where false
}

apply Notification "notify-service" to Service {
    log("applying Notification " + name + " to Service " + host.name + "!" + service.name)
    command = "dummy"
    users = ["u"]
    assign where host.name == "h" && service.name == "s"
    assign where host.name == "h" && service.name == "s"
}

apply Notification "notify-service-warn" to Service {
    log("applying Notification " + name + " to Service " + host.name + "!" + service.name)
    command = "dummy"
    users = ["u"]
    assign where host.name == "404" && service.name == "s"
    assign where host.name == "404" && service.name == "s"
}

apply Notification "notify-service-true" to Service {
    log("applying Notification " + name + " to Service " + host.name + "!" + service.name)
    command = "dummy"
    users = ["u"]
    assign where true
}

apply Notification "notify-service-false" to Service {
    log("applying Notification " + name + " to Service " + host.name + "!" + service.name)
    command = "dummy"
    users = ["u"]
    assign where false
}

// ApplyRule::RegisterType("ScheduledDowntime", { "Host", "Service" });

apply ScheduledDowntime "dt-host" to Host {
    log("applying ScheduledDowntime " + name + " to Host " + host.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where host.name == "h"
    assign where host.name == "h"
}

apply ScheduledDowntime "dt-host-warn" to Host {
    log("applying ScheduledDowntime " + name + " to Host " + host.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where host.name == "404"
    assign where host.name == "404"
}

apply ScheduledDowntime "dt-host-true" to Host {
    log("applying ScheduledDowntime " + name + " to Host " + host.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where true
}

apply ScheduledDowntime "dt-host-false" to Host {
    log("applying ScheduledDowntime " + name + " to Host " + host.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where false
}

apply ScheduledDowntime "dt-service" to Service {
    log("applying ScheduledDowntime " + name + " to Service " + host.name + "!" + service.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where host.name == "h" && service.name == "s"
    assign where host.name == "h" && service.name == "s"
}

apply ScheduledDowntime "dt-service-warn" to Service {
    log("applying ScheduledDowntime " + name + " to Service " + host.name + "!" + service.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where host.name == "404" && service.name == "s"
    assign where host.name == "404" && service.name == "s"
}

apply ScheduledDowntime "dt-service-true" to Service {
    log("applying ScheduledDowntime " + name + " to Service " + host.name + "!" + service.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where true
}

apply ScheduledDowntime "dt-service-false" to Service {
    log("applying ScheduledDowntime " + name + " to Service " + host.name + "!" + service.name)
    author = "dummy"
    comment = "dummy"
    ranges = {}
    assign where false
}