Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair DSL Namespace values being constant broken in #9627 #9662

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Repair DSL Namespace values being constant broken in #9627 #9662

merged 2 commits into from
Feb 20, 2023

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Feb 10, 2023 •
edited
Loading 

master before #9627 (a0286e9c6) as well as this PR:

<1> => namespace n { x = 42; x = 42 }
                             ^^^^^^
Constant must not be modified.
<2> =>

HEAD of #9627 (24b57f0d3):

<1> => namespace n { x = 42; x = 42 }
null
<2> =>

closes #9656

@Al2Klimov Al2Klimov added the core/build-fix Follow-up fix, not released yet label Feb 10, 2023
@Al2Klimov Al2Klimov added this to the 2.14.0 milestone Feb 10, 2023
@cla-bot cla-bot bot added the cla/signed label Feb 10, 2023
@icinga-probot icinga-probot bot added area/configuration DSL, parser, compiler, error handling core/quality Improve code, libraries, algorithms, inline docs labels Feb 10, 2023
@Al2Klimov
Repair DSL Namespace values being constant broken in #9627
02df94a 
master before #9627 (a0286e9):

<1> => namespace n { x = 42; x = 42 }
                             ^^^^^^
Constant must not be modified.
<2> =>

HEAD of #9627 (24b57f0):

<1> => namespace n { x = 42; x = 42 }
null
<2> =>
@Al2Klimov
Make globals.Internal values non-const by default
683095a 
That namespace is internal anyway.

Previous commit, icinga2 console:
Error: Constants must not be removed.

This commit fixes it.
@julianbrost julianbrost merged commit bda8be3 into master Feb 20, 2023
@icinga-probot icinga-probot bot deleted the Repair#9627 branch February 20, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/configuration DSL, parser, compiler, error handling cla/signed core/build-fix Follow-up fix, not released yet core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @julianbrost