Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CheckResultReader which has been deprecated for 5 major versions #9714

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Remove CheckResultReader which has been deprecated for 5 major versions #9714

merged 1 commit into from
Apr 3, 2023

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov added this to the 2.14.0 milestone Mar 1, 2023
@Al2Klimov Al2Klimov requested a review from lippserd March 1, 2023 16:18
@icinga-probot icinga-probot bot added area/compat Deprecated features from 1.x core/quality Improve code, libraries, algorithms, inline docs enhancement New feature or request labels Mar 1, 2023
@cla-bot cla-bot bot added the cla/signed label Mar 1, 2023
lippserd
lippserd previously approved these changes Mar 6, 2023
View reviewed changes
@Al2Klimov Al2Klimov force-pushed the CheckResultReader branch from aa1585c to cc872da Compare April 3, 2023 09:39
julianbrost
julianbrost approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CheckResultReader was a compatibility feature for Icinga 1.x and there were no requests for in in #6031 or #6307, so finally removing it should be fine.

@julianbrost julianbrost enabled auto-merge April 3, 2023 13:58
@julianbrost julianbrost merged commit f3b1485 into master Apr 3, 2023
@icinga-probot icinga-probot bot deleted the CheckResultReader branch April 3, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

@lippserd lippserd lippserd left review comments

Assignees
No one assigned
Labels
area/compat Deprecated features from 1.x cla/signed core/quality Improve code, libraries, algorithms, inline docs enhancement New feature or request
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Al2Klimov @julianbrost @lippserd