Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Monitoring Basics: make Event Commands not a subsection of Dependencies #9741

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Docs: Monitoring Basics: make Event Commands not a subsection of Dependencies #9741

merged 1 commit into from
Apr 17, 2023

Conversation

Al2Klimov
Copy link
Member

but an own and equal section.

@Al2Klimov Al2Klimov added bug Something isn't working area/documentation End-user or developer help labels Apr 4, 2023
@Al2Klimov Al2Klimov requested a review from bobapple April 4, 2023 10:21
@cla-bot cla-bot bot added the cla/signed label Apr 4, 2023
@Al2Klimov
Copy link
Member Author

Please render it on the docs site (staging, not prod, of course) for before/after comparison.

Al2Klimov
Al2Klimov commented Apr 17, 2023
View reviewed changes
Copy link
Member Author

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a must-have for 2.14, but a must-have for docs site – and 2.14 is the next latest tag 🤷‍♂️

Before

Opera Momentaufnahme_2023-04-17_105745_localhost

After

Opera Momentaufnahme_2023-04-17_110156_localhost

@Al2Klimov Al2Klimov requested review from julianbrost and removed request for bobapple April 17, 2023 09:05
julianbrost
julianbrost requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the order of sections is wrong, not the level. ### Event Commands should be a subsection of ## Commands, but somehow ## Dependencies ended up between ### Notification Commands and ### Event Commands.

@Al2Klimov Al2Klimov force-pushed the docs-monitoring-basics-make-event-commands-not-a-subsection-of-dependencies branch from 9f99db2 to b91c14d Compare April 17, 2023 11:35
Al2Klimov
Al2Klimov commented Apr 17, 2023
View reviewed changes
Copy link
Member Author

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opera Momentaufnahme_2023-04-17_134040_localhost

@Al2Klimov Al2Klimov force-pushed the docs-monitoring-basics-make-event-commands-not-a-subsection-of-dependencies branch from b91c14d to 5638b3b Compare April 17, 2023 11:43
@Al2Klimov Al2Klimov requested a review from julianbrost April 17, 2023 11:43
@julianbrost julianbrost enabled auto-merge April 17, 2023 12:52
@julianbrost julianbrost added this to the 2.14.0 milestone Apr 17, 2023
@julianbrost julianbrost merged commit a15ce7f into master Apr 17, 2023
@icinga-probot icinga-probot bot deleted the docs-monitoring-basics-make-event-commands-not-a-subsection-of-dependencies branch April 17, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/documentation End-user or developer help bug Something isn't working cla/signed
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @julianbrost