-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POST /v1/objects: allow array of attrs to undo modifications of #9783
Conversation
b7606df
to
57f7f76
Compare
Looks fine, so you can go ahead with that:
|
Invalid usages
Valid usages
Admittedly the latter doesn’t work exactly as intended, leaving vars.lolcat=null, but only till the next reload. |
Temporarily, I was worried whether this would actually work properly in clusters, but seems like this was actually also implemented for v2.4 (that's when icinga2/lib/remote/apilistener-configsync.cpp Lines 179 to 199 in a3dabde
And it looks like this is actually working fine after being mostly unused for years. I guess you can also get lucky sometimes. |
@Al2Klimov This should probably fix (or at least ref) some issues. Can you please add that before merging? |
…ibutes, i.e. to restore the config files' values. #9783
in addition to the mapping of ones to modify.
Restoration is also a kind of modification I guess.
See changed docs.
fixes #8709
closes #7986
TODO