-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log reconnects #351
Comments
|
The idea with the struct and the callbacks is that the retry package is the only place that handles the error / retry conditions and not the consumers of that package. In the logs I would expect something like this:
For the sake of completeness, the |
Al2Klimov
added a commit
that referenced
this issue
Sep 22, 2021
Al2Klimov
added a commit
that referenced
this issue
Sep 22, 2021
Al2Klimov
added a commit
that referenced
this issue
Sep 22, 2021
Al2Klimov
added a commit
that referenced
this issue
Sep 22, 2021
E.g. the first "connection refused" and the first "hostname mismatch". refs #351
Al2Klimov
added a commit
that referenced
this issue
Sep 22, 2021
... to give the admin the all-clear. refs #351
Al2Klimov
added a commit
that referenced
this issue
Sep 23, 2021
... to give the admin the all-clear. refs #351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, Icinga DB only logs that it will retry reconnecting to the database (and Redis?). I think it makes sense to also log reconnects then. We could add a struct for optional args to the
retry.WithBackoff()
function which provides settings forOnError
andOnRetry
callbacks. The timeout should be moved there as well then.The text was updated successfully, but these errors were encountered: