Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema: add table icingadb_schema #65

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

Al2Klimov
Copy link
Member

fixes #59

@Al2Klimov Al2Klimov added this to the 1.0.0-rc1 milestone Nov 29, 2019
@Al2Klimov Al2Klimov requested a review from lippserd November 29, 2019 15:15
@Al2Klimov Al2Klimov force-pushed the feature/schema-version-info-59 branch from 72a72c1 to 3fed668 Compare November 29, 2019 15:19
@lippserd
Copy link
Member

lippserd commented Dec 4, 2019

CREATE TABLE icingadb_schema (
  id int(10) unsigned NOT NULL AUTO_INCREMENT,
  version varchar(255) NULL DEFAULT NULL,
  timestamp bigint(20) unsigned NOT NULL,
  PRIMARY KEY(id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;

INSERT INTO icingadb_schema (version, timestamp)
  VALUES ('v1.0.0-rc1', CURRENT_TIMESTAMP() * 1000);

@Al2Klimov Al2Klimov force-pushed the feature/schema-version-info-59 branch 2 times, most recently from 6ddafe5 to e1f1b5c Compare December 4, 2019 10:11
@lippserd
Copy link
Member

lippserd commented Dec 6, 2019

CREATE TABLE icingadb_schema (
  id int(10) unsigned NOT NULL AUTO_INCREMENT,
  version smallint(5) unsigned NOT NULL,
  timestamp bigint(20) unsigned NOT NULL,
  PRIMARY KEY(id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;

INSERT INTO icingadb_schema (version, timestamp)
  VALUES (1, CURRENT_TIMESTAMP() * 1000);

Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above 😆

@Al2Klimov Al2Klimov force-pushed the feature/schema-version-info-59 branch from e1f1b5c to 9f8cebf Compare December 6, 2019 14:58
@Al2Klimov Al2Klimov requested a review from lippserd December 6, 2019 14:58
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Al2Klimov Al2Klimov merged commit 28ca90a into master Dec 6, 2019
@Al2Klimov Al2Klimov deleted the feature/schema-version-info-59 branch December 6, 2019 16:08
lippserd added a commit that referenced this pull request May 25, 2021
db.BulkExec(): Use ExecContext() instead of Query()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema version information
2 participants