Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions: Add Phpstan #187

Merged
merged 18 commits into from
Sep 6, 2023
Merged

Github Actions: Add Phpstan #187

merged 18 commits into from
Sep 6, 2023

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 self-assigned this Jun 19, 2023
@cla-bot cla-bot bot added the cla/signed label Jun 19, 2023
@yhabteab yhabteab force-pushed the phpstan branch 15 times, most recently from 6724d20 to ed3468f Compare August 21, 2023 12:24
@yhabteab
Copy link
Member

The remaining errors should be fine, once all phpstan branches of ipl libraries are merged and the nightly branch is updated.

.github/workflows/php.yml Outdated Show resolved Hide resolved
application/controllers/ReportController.php Outdated Show resolved Hide resolved
library/Reporting/Mail.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/ScheduleForm.php Outdated Show resolved Hide resolved
phpstan.neon Outdated Show resolved Hide resolved
@nilmerg nilmerg added this to the 1.0.0 milestone Sep 1, 2023
@yhabteab yhabteab force-pushed the phpstan branch 3 times, most recently from 81f78cc to 3430d00 Compare September 4, 2023 07:32
Copy link
Contributor Author

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

yhabteab
yhabteab previously approved these changes Sep 4, 2023
@yhabteab yhabteab added the enhancement New feature or request label Sep 4, 2023
library/Reporting/Mail.php Outdated Show resolved Hide resolved
library/Reporting/Mail.php Outdated Show resolved Hide resolved
@nilmerg nilmerg merged commit ca78cf1 into master Sep 6, 2023
@nilmerg nilmerg deleted the phpstan branch September 6, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants