-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions: Add Phpstan #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
phpstan
branch
15 times, most recently
from
August 21, 2023 12:24
6724d20
to
ed3468f
Compare
The remaining errors should be fine, once all phpstan branches of ipl libraries are merged and the nightly branch is updated. |
sukhwinder33445
commented
Aug 29, 2023
sukhwinder33445
commented
Sep 1, 2023
yhabteab
force-pushed
the
phpstan
branch
3 times, most recently
from
September 4, 2023 07:32
81f78cc
to
3430d00
Compare
sukhwinder33445
commented
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
yhabteab
previously approved these changes
Sep 4, 2023
nilmerg
reviewed
Sep 6, 2023
nilmerg
requested changes
Sep 6, 2023
nilmerg
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.