Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override scheduled schedules with the new ones #221

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

yhabteab
Copy link
Member

Fixes a daemon crash when reloading the schedules after 5m.

Removing Schedule1 as it either no longer exists in the database or its config has been changed
PHP Fatal error:  Uncaught InvalidArgumentException: Task Schedule1 not scheduled in /usr/local/src/ipl-scheduler/src/Scheduler.php:159
Stack trace:
#0 /usr/share/icingaweb2-modules/reporting/application/clicommands/ScheduleCommand.php(63): ipl\Scheduler\Scheduler->remove(Object(Icinga\Module\Reporting\Schedule))
#1 /usr/share/icinga-php/vendor/vendor/react/event-loop/src/ExtEvLoop.php(144): Icinga\Module\Reporting\Clicommands\ScheduleCommand->Icinga\Module\Reporting\Clicommands\{closure}(Object(React\EventLoop\Timer\Timer))
#2 [internal function]: React\EventLoop\ExtEvLoop->React\EventLoop\{closure}()
#3 /usr/share/icinga-php/vendor/vendor/react/event-loop/src/ExtEvLoop.php(208): EvLoop->run(2)
#4 /usr/share/icinga-php/vendor/vendor/react/event-loop/src/Loop.php(55): React\EventLoop\ExtEvLoop->run()
#5 [internal function]: React\EventLoop\Loop::React\EventLoop\{closure}()
#6 {main}
  thrown in /usr/local/src/ipl-scheduler/src/Scheduler.php on line 159

@cla-bot cla-bot bot added the cla/signed label Nov 14, 2023
@yhabteab yhabteab self-assigned this Nov 14, 2023
@yhabteab yhabteab added the bug Something isn't working label Nov 14, 2023
@yhabteab yhabteab added this to the 1.0.1 milestone Nov 14, 2023
@yhabteab yhabteab requested a review from nilmerg November 14, 2023 15:53
@yhabteab yhabteab merged commit e001b4c into main Nov 15, 2023
7 checks passed
@yhabteab yhabteab deleted the fix-daemon branch November 15, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants