Provide migration hook

[yhabteab]

For testing this hook you can use these PRs from Reporting and X509. But make sure you have created some report schedules with the master branch beforehand.

You can also use this example hook to test PHP code migrations:

diff --git a/library/Icinga/Application/ApplicationBootstrap.php b/library/Icinga/Application/ApplicationBootstrap.php
index 4e7ddd954..b909aa20e 100644
--- a/library/Icinga/Application/ApplicationBootstrap.php
+++ b/library/Icinga/Application/ApplicationBootstrap.php
@@ -7,6 +7,7 @@ use DirectoryIterator;
 use ErrorException;
 use Exception;
 use Icinga\Application\ProvidedHook\DBMigration;
+use Icinga\Application\ProvidedHook\DummyMigrator;
 use ipl\I18n\GettextTranslator;
 use ipl\I18n\StaticTranslator;
 use LogicException;
@@ -770,6 +771,7 @@ abstract class ApplicationBootstrap
     protected function registerApplicationHooks(): self
     {
         Hook::register('migration', DBMigration::class, DBMigration::class);
+        Hook::register('migration', DummyMigrator::class, DummyMigrator::class);
 
         return $this;
     }

<?php

namespace Icinga\Application\ProvidedHook;

use Icinga\Application\Hook\PHPMigrationHook;

class DummyMigrator extends PHPMigrationHook
{
    protected const EXECUTE_AFTER_SCHEMA_VERSION = '2.12.0';

    public function getDescription(): string
    {
        return $this->translate('This is Icinga Web 2');
    }

    public function getName(): string
    {
        return $this->translate('Icinga Web 2');
    }

    public function apply(): bool
    {
        return $this->run(static::VERSION, function () {
            var_dump("Dummy");
        });
    }
}

resolves #5043

[flourish86]

Collapse Toggle Icons

Please invert the arrow direction. We use. icons to reflect actions not states. So, caret-down when collapsed and vice versa.

List Item "Migrate" Button

Please apply the style from the mockups

Disabled style

The buttons still look clickable, even when they are disabled.

Apply All Button

"Apply All" is too generic. Please provide a clearer label, like "Migrate all modules".

Visual aligment

Please align on baseline

Collapse state won't be conserved on auto-refresh

Collapse button position

While it makes sense to have the collapse button stay in place for interaction reasons (button doesn't "jump"), clarity suffers from a structural aspect, when the migration list is expanded. Please move the button to the bottom of the list.

Collapse button width

The button doesn't need span the full width. It's doesn't make a difference at first, but when focussed it looks awkward. Probably display: inline-block will easily fix this.

[yhabteab]

List Item "Migrate" Button

Please apply the style from the mockups

The mockups uses the style of an action/button link but this is a regular submit button and ist styled like another submit buttons of Icinga Web 2. So, why should we change it here?

While it makes sense to have the collapse button stay in place for interaction reasons (button doesn't "jump"), clarity suffers from a structural aspect, when the migration list is expanded. Please move the button to the bottom of the list.

A details/summary tag is standardised to always render the details after the collapse/expand marker. But if you insist on changing this behavior, you can try, cause I'm not and wasn't able to do this.

[yhabteab]

For reference here're the mockups!

[yhabteab]

List Item "Migrate" Button

Please apply the style from the mockups

The mockups uses the style of an action/button link but this is a regular submit button and ist styled like another submit buttons of Icinga Web 2. So, why should we change it here?

Done!

[flourish86]

Not sure about the reason, but your branch messes with the Icinga DB list items

1. I find it acceptable to label to the list item Button "Apply" since we're talking about a list of (pending) migrations, though it differs from the mockups.

Following this reasoning it doesn't make sense to label the "global" button this way, though. "Apply All Modules" just doesn't make sense, since you aren't list modules.
"Apply All Module Migrations" would be correct. I would rather go for "Apply all", though.

2. Please remove the button background according to the mockups. It's less about default styles than visual clarity in this case and the button shape makes the element too distracting from the headline and the content.

[flourish86]

List Item "Migrate" Button

Please apply the style from the mockups

The mockups uses the style of an action/button link but this is a regular submit button and ist styled like another submit buttons of Icinga Web 2. So, why should we change it here?

Done!

Your point makes actually sense, sometimes I'm living too much in Icinga Db Web world. 😅 Maybe we should address this globally for icingaweb2 in a different context.

outdated