Add scope remover processor #132
Conversation
| for value in attributes.get(attribute, [None]): | ||
| if '@' in value: | ||
| new_values.append(value.split('@')[0]) | ||
| attributes[attribute] = new_values |
There was a problem hiding this comment.
This will remove any attribute values without a @, and leave only values that had a scope (but with the scope-part removed). This is not clear from the class name.
If this was not intentional you only need to remove the if '@' in value clause (I'm ignoring the problem described in the comment above)
for value in attributes.get(attribute, [None]):
value_with_no_scope = value.split('@')[0]
new_values.append(value_with_no_scope)There was a problem hiding this comment.
The idea is that the deployer uses this microservice for attributes that are scoped. I agree though that removing the attribute entirely in case it is not scoped, doesn't make much sense and will just add to confusion. I will revisit this
| def process(self, internal_data, attribute, **kwargs): | ||
| attributes = internal_data.attributes | ||
| new_values = [] | ||
| for value in attributes.get(attribute, [None]): |
There was a problem hiding this comment.
If attribute is not found, [None] will be returned and value will be set to None. Then value.split() will fail. We should probably check if the attribute is there, and then process the values. If attribute is not there, I would raise an AttributeProcessorWarning.
| new_values = [] | ||
| values = attributes.get(attribute, [None]) | ||
| if values: | ||
| for value in attributes.get(attribute, [None]): |
There was a problem hiding this comment.
You already have values set, no need to get() from attributes again ;)
btw, if you want to make this "prettier", you can invert the conditional and remove the else clause and indentation
if not correct:
raise SomeErrror # processing will stop here
# "implied" else can go here now
do_stuff(...)
do_other_stuff(...)This also moves the error handling closer to the cause, which makes things a bit more readable.
Adds a processor for the AttributeProcessor microservice that removes the scope from scoped attributes