Workaround for xmlsec breaking when SHA1 is deprecated: Allow signature and digest algorithm as parameters ... #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for metadata generation. Also using sha256 as default to prevent xmlsec breaking on systems where sha1 is disabled.
Details
Pull allows for additional parameters --signature-algorithm and --digest-algorithm in scripts/saml_metadata.py which are applied when signing is true (the default).
Given Strings should reference xmldsig (mirroring frontend/backend configuration) like "SIG_RSA_SHA256".
Change of behavior
Defaults in scripts/saml_metadata.py select SHA256 instead of SHA1 (SHA1 is just the default in pysaml2) to avoid metadata generation breaking on systems where SHA1 is already deprecated and thus xmlsec1 unable to sign metadata. Which was the reason for the change in the first place (RHEL9).
All Submissions: