Per-SP configuration for LDAP attribute store microservice #60
Conversation
Added functionality to the LDAP attribute store microservice so that all details include the LDAP directory details can be configured on a per-SP basis. Also added better logging.
| config = self.config[spEntityID] | ||
| configClean = copy.deepcopy(config) | ||
| if 'bind_password' in configClean: | ||
| configClean['bind_password'] = 'XXXXXXXX' |
There was a problem hiding this comment.
As asked above, is this line a leftover from debugging?
There was a problem hiding this comment.
No. The intent is to log the configuration at the DEBUG level but blank out any bind password included in the configuration so that passwords are never logged.
There was a problem hiding this comment.
OK, thanks for the explanation, I see now how it's used while logging.
| config = self.config | ||
| configClean = copy.deepcopy(config) | ||
| if 'bind_password' in configClean: | ||
| configClean['bind_password'] = 'XXXXXXXX' |
There was a problem hiding this comment.
Is this, together with the similar line at the comment below, a leftover from debugging?
There was a problem hiding this comment.
No. The intent is to log the configuration at the DEBUG level but blank out any bind password included in the configuration so that passwords are never logged.
There was a problem hiding this comment.
OK, thanks for the explanation, I see now how it's used while logging.
Added functionality to the LDAP attribute store microservice
so that all details include the LDAP directory details can
be configured on a per-SP basis. Also added better logging.