Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Configurable Client ID generator function #29

Merged
merged 2 commits into from
May 5, 2021
Merged

Configurable Client ID generator function #29

merged 2 commits into from
May 5, 2021

Conversation

peppelinux
Copy link
Member

A custom Client ID generator function can be defined Registration endpoint configuration

  • feat: "client_id_generator"
  • feat: default client_id length up to 16 digits
    "registration": {
      "path": "registration",
      "class": "oidcop.oidc.registration.Registration",
      "kwargs": {
        "client_authn_method": None,
        "client_secret_expiration_time": 432000,
        "client_id_generator": 'oidcop.oidc.registration.random_client_id'
      }

A custom Client ID generator function can be defined Registration endpoint configuration

* feat: "client_id_generator"
* feat: default client_id length up to 16 digits

````
    "registration": {
      "path": "registration",
      "class": "oidcop.oidc.registration.Registration",
      "kwargs": {
        "client_authn_method": None,
        "client_secret_expiration_time": 432000,
        "client_id_generator": 'oidcop.oidc.registration.random_client_id'
      }
````
@peppelinux peppelinux requested review from rohe, angelakis and nsklikas May 4, 2021 15:38
@rohe
Copy link
Collaborator

rohe commented May 4, 2021

OK, I'd like that to be:

"registration": {
      "path": "registration",
      "class": "oidcop.oidc.registration.Registration",
      "kwargs": {
        "client_authn_method": None,
        "client_secret_expiration_time": 432000,
        "client_id_generator": { 
           "class": 'oidcop.oidc.registration.random_client_id',
           "kwargs: {}
       }
    }

There is pattern there I'd like to maintain.

@peppelinux
Copy link
Member Author

peppelinux commented May 4, 2021

Done here
5f0e79e

once this feature will be merged I'll updated docs branch with this specification and example

@rohe rohe merged commit b484a00 into develop May 5, 2021
@peppelinux peppelinux deleted the cid_gen branch May 5, 2021 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants