[Strengthen Encryption] PySAML2 Encrypted Assertions work with Shibboleth SP 3 #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieved #745
I have been forced for some time to disable assertion encryption due to an incompatibility issue between my pysaml2 based IdP and a Shibboleth SP, with this patch I got it to work.
It solved two weakness in pysaml2 encryption method, that ShibSP highlighted as follows
and also
Another warning about pysaml2 encryption with Shib SP is the follow:
pefim
.encrypt_assertion
,encrypt_advice_attributes
,encrypt_assertion_self_contained
works great instead.Using PEFIM we'll have, shib SP side, this message
All Submissions: