-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend characters with European non-latin set #105
Conversation
Wow, this is insane work, thank you for adding all of these characters! Due to the sheer number of characters added, I'll need a bit of time to review this before merging it in. Especially since we are about to release #112 which might change the appearance of certain characters. |
Coming back to this, once again amazed at the number of glyphs added to the glyphset. I've looked through them from an english-speaking perspective and see no obvious bugs, but I am going to release this as a "beta" for a few days and see if anyone sees anything I might have missed. Thank you once again for the work you have put into this, it is very much appreciated. |
This pull request contains all implemented european non-latin letters, without margins.
While definitions seem correct to me, with the current shape implementation, there are few issues to fix alongside:
1. Characters longer than 5px are overlapping other characters.
Examples with Georgian and Armenian scripts:
2. Descent pixels, which are lower than 7px border, seem to be cut off, even with correct descent parameter: