Added Missing Hungarian letters #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for taking the time to add new characters! However, looks like these characters show up in Minecraft as having two accents above the letters rather than tildes. Could you please update the glyphs to instead use these accents? I'd recommend closing this PR and creating a new branch to avoid conflicts, as the PR to add Cyrillic glyphs changed the encoding of the font which can get messy.
|
|
|
IdreesInc
requested changes
Oct 6, 2022
IdreesInc
reviewed
Oct 6, 2022
|
Apologies for the delay, looks good to me. Thanks for taking the time to add these characters! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ő, Ő, ű, and Ű were missing from the available letters. I added the former two, by copying the tilde variants, and constructed the ű and Ű by just copying a few pixels.