Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix holidays calculations #748

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix holidays calculations #748

merged 1 commit into from
Dec 18, 2023

Conversation

dmtrek14
Copy link
Collaborator

  • Change how we get used/scheduled hours if reference date is in the future
  • Update calculation in summary report action to subtract used hours
  • Rename variable to match the ui for clarity

anarute
anarute approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@anarute anarute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmtrek14
Fix holidays calculations
d93a9b9 
- Change how we get used/scheduled hours if reference date is in the future
- Update calculation in summary report action to subtract used hours
- Rename variable to match the ui for clarity
@dmtrek14 dmtrek14 merged commit caa6fc5 into main Dec 18, 2023
2 checks passed
@dmtrek14 dmtrek14 deleted the fix-vacation-math branch December 18, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anarute anarute anarute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmtrek14 @anarute