Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print out user-friendly error message #1160

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

dpino
Copy link
Member

@dpino dpino commented Jul 26, 2018

Fixes #707 and #759

snabb config commands no longer return stack traces, but the error message contains the filename and line number where the parsing error occurred. This information is not relevant for an user. Also the user doesn't know the issue is in the path. About the error message itself, I left it as it is. Perhaps it's too fine-grained detail for an user, but useful imho. Example:

$ sudo ./snabb config set -s snabb-softwire-v2 lwaftr \
   "/softwire-config/internal-interface/reassembly-max-fragments-per-packet" "332167"
Invalid path: Struct has no field named 'reassembly-max-fragments-per-packet'.

Copy link

@wingo wingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dpino dpino merged commit c69a042 into Igalia:lwaftr Sep 5, 2018
@dpino dpino deleted the fix-issue-707 branch September 5, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants