Allow setting flow-label in ingress packets #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takikawa
reviewed
Oct 12, 2018
| @@ -723,6 +723,12 @@ module snabb-softwire-v2 { | |||
| "Maximum packet size to recieve on the IPv6 interface."; | |||
| } | |||
|
|
|||
| leaf flow-label { | |||
| type uint32; | |||
There was a problem hiding this comment.
This defaults to 0 right? Is it worth putting in an explicit default: 0; clause here or is that unnecesary? (I noticed some other leaves have such defaults)
takikawa
approved these changes
Oct 12, 2018
wingo
added a commit
that referenced
this pull request
Mar 5, 2019
This commit makes four changes:
(1) On the individual revision nodes in a schema, the revision date is
now stored under `date` instead of `value`.
(2) Schemas now have a `last_revision` property, indicating the date
of the most recent revision.
(3) This revision now gets serialized into compiled configurations.
(4) When loading compiled configurations, we check that the compiled
file's revision date corresponds to the what we are expecting.
Fixes #1183.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an infrastructure with several lwAFTRs if something goes wrong it may be hard to figure out which lwAFTR instance is causing trouble. Allowing each lwAFTR set their own flow-label can help to identify which ingress packets where processed by which lwAFTR.