ljsyscall: ensure size matches mask for get_mempolicy #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a call to get_mempolicy, the maxnode argument should match the size of the given nodemask to avoid buffer overruns. This commit ensures the size is ok when ljsyscall generates the nodemask structure.
dpino
approved these changes
Dec 12, 2018
|
@justincormack pinging you in case this bug is also in ljsyscall master. |
eugeneia
pushed a commit
to snabbco/snabb
that referenced
this pull request
Jan 7, 2019
On a call to get_mempolicy, the maxnode argument should match the size of the given nodemask to avoid buffer overruns. This commit ensures the size is ok when ljsyscall generates the nodemask structure. Cherry-picked from: Igalia#1198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as snabbco#1268 on the upstream repo with just slightly different code. This version seems to work for me on snabb2, but the upstream PR didn't quite work for me.
Putting this here because we had discussed merging this via the lwaftr branch and then upstreaming it.