bLwram ndp #208

kbara · 2016-01-26T13:59:52Z

This branch is not ready for merging, and is subject to forced updates. It's a sketch to show the structure of one of the two chunks of NDP functionality we need.

wingo · 2016-01-26T14:04:03Z

src/apps/lwaftr/ipv6_apps.lua

+      transmit(onorth, o.ns_pkt)
+   end
+
+   for _=1,math.min(link.nreadable(isouth), link.writeable(onorth)) do


Following snabbco#656 we should process all readable packets.

aka ditch the link.writeable check?

wingo · 2016-01-26T14:14:16Z

Looking good in the small. I am missing the big picture though: what's the other chunk of NDP that's needed? How does it all fit together? Is it not possible to determine the router on the ipv6 side automatically, without specifying it in the lwaftr conf?

kbara · 2016-01-26T14:18:03Z

The other chunk is sending out neighbor announcements and solicitiations and listening for solicited neighbor announcements. The best theory as to why OpenWRT wouldn't talk to our lwaftr revolved around the lwaftr not doing either.

Discovering routers automatically is doable, but opens several interesting cans of worms.

wingo · 2016-01-26T14:37:58Z

Since you have been deep in the RFCs recently kbarone would you mind peering into the wormcans and letting us know what's in there? :)

Also, I would expect that we should periodically send out the solicitation requests -- is that correct? I think probably not using a timer though, in light of snabbco#664 (comment).

kbara · 2016-01-26T21:59:53Z

Discussed out-of-band. And yes, that is correct.

kbara · 2016-02-04T09:54:22Z

Yes, pred stands for predicate... but the code says:

local function required_if(key, pred)
   return function(config)
      if config[pred] then
         error('missing required configuration key "'..key..'"')
      end
   end
end

I could see predicate(config) or config[somekey], but config[pred] looks like the idea was switched halfway through writing it. What am I missing? @wingo

wingo · 2016-02-04T09:55:38Z

you can change it if you like, the predicate is whether the key is present i guess

kbara · 2016-02-04T09:56:30Z

Ok; I'll change it in a different PR after this is ready to land and landed.

wingo · 2016-02-04T14:31:42Z

You will need to rebase this onto lwaftr_starfruit. Be sure to not pull in extraneous commits. Sorry for the noise and thanks!

kbara · 2016-02-04T14:37:54Z

Shall do in a new PR, after integrating it with your rename patch.

e587f8c55 Merge pull request #225 from vavrusa/master 5ea3a881e bpf: add missing constants for linux 4.10 - 4.15 2c691e5a7 Merge pull request #224 from wingo/lseek-syscall-tweak ae38bdbd7 Make "offset" arg to lseek a signed integer 5cb3b6950 Merge pull request #221 from wingo/util-ls-fix 8e0874609 Promptly close util.ls() dir fd; fix bug with deleted entries 277517436 Merge pull request #220 from sileht/master 8e48fd094 linux/nl.lua: Use ndmsg struct instead of rtmsg for neighbors 3e482bc4e Merge pull request #215 from qsn/gettid 57520cce3 expose gettid db1a88e94 Merge pull request #214 from jsitnicki/sof-flags-linux 270a6e611 Add missing type for struct scm_timestamping for Linux e49232047 Add missing SCM_* constants for Linux timestamping API 60fcc6b48 Add constants for SOF_* flags for Linux 26ac34851 Merge pull request #210 from alexandergall/linux-if-ioctls 3e6d3e27c Merge pull request #211 from fperrad/deb d425a22b2 dummy changelog b27eca538 update .gitignore 92292aa4b debian files be257a7e1 debian files generated by lua-create-gitbuildpackage-layout 50a02b94b Add some SIOC{G,S}IF* ioctls for Linux ee90324 Merge pull request #209 from justincormack/osx_clock ee17863 Add CLOCK_ constants for OSX 178d244 Merge pull request #208 from justincormack/holes 61450f5 Add SEEK_DATA and SEEK_HOLE constants 9a7b584 Add memfd fnctl sealing support 99beaf5 more test fixes for memfd cc221e4 fix ctest for new fcntl changes, typowq 56c4c76 fix ctest for new fcntl changes 96073cc fix typo 7a73e8a Add more constants for fcntl, memfd 8d3034c Fix ppc64le syscall numbers for newer calls 62828f6 Merge pull request #206 from johnae/master c4002b6 The spook project is using ljsyscall. 0b266e8 Merge pull request #205 from lukego/close-fd-safely ad91aa9 Add more protection against fd double-close c8baf9e Merge pull request #202 from justincormack/dockerignore 66843c5 Use dockerignore to simplify Dockerfile 7b7211d Merge pull request #200 from justincormack/redo-dockerfile a779caa Docker Cloud does not start processes at priority 0, remove from test b85382d Rework Dockerfile and tests 24f7789 Merge pull request #199 from vavrusa/master 2ecf486 linux/constants: added new BPF map and prog types 00c1949 use Alpine 3.4 for docker build 0bcafc6 Merge pull request #196 from kbara/removecunused a4217a8 Merge pull request #195 from kbara/fixgetcpu ee67430 Remove unused variables from c.lua 4b2e0b2 Fix getcpu: the cpu argument was incorrectly given the node variable previously 214550a update changelog and rockspec for 0.12 release 21f3fd8 Merge pull request #192 from vavrusa/master 0da437f linux/bpf_prog_load: support custom kernel builds 9981190 fix missing vhangup f245114 Merge pull request #191 from vavrusa/linux-perf-open 93558c1 linux: added support for tracing/performance counters 0511fb8 Merge pull request #190 from vavrusa/master 1f141ca linux: added new constants (e.g. attach BPF to socket) 36274f3 linux/bpf: added strflag support 4fd3bd6 Merge pull request #189 from vavrusa/master aaa89cb linux: added support for eBPF e095295 linux: added new syscall numbers (up to __nr_bpf) 1e079c4 test calls container so just needs file to run d92625e define a docker compose test 5f14711 Merge pull request #188 from aperezdc/fix-if-nameindex 8915a83 Close socket immediately after error in if_nametoindex() 96c0286 use addons for travis, as learned at fosdem 71241e0 update changelog for unreleased changes 559b499 ignore audit arch constant 5d867d3 new architectures do not have open, will use openat 49d9ff9 test issues with new constants 7cd460e aarch64 audit constants for seccomp 6249e99 more docker examples dd00af9 rockspec fix d20033b rockspec for new release fb17244 update copyright years 9d87597 more Changelog tweaks before release 53856b0 typo 1881526 sometimes winsz is 0, eg if terminal not set up ab0c08d add error message a1c207e update Changelog for forthcoming 0.11 release ce12fb2 addDocker hub to README 602a2b3 fix osx fstatat to use 32 bit stat type, as cannot find how to call to get 64 bit one 8a0a6ad Now have arm machines with working seccomp d14bd38 Appears that setting maac address on lo often works 6e878a1 remove debug print from test 30e9b5b allow skip on EPERM for adjtimex bff3e90 Add strace in Docker image for convenient debugging e67fa31 Use alpine 3.3 for Docker 5148bc3 fix ipv6 tests 185c1a6 more failures with no ipv6 98cc9a2 more fixes for ipv4 only environments for netlink tests 248a935 fix bind errors in environments that do not support ipv6 0eacd64 clean up travis file 5fb71b6 switch to newer Ubuntu in travis 8235724 fix more constant checks not in headers 8dff4ef constants missing on travis db51b08 update Changelog 7540b04 add new rtnetlink values, so tests work under docker 22604b8 remove test that fails in some environments d431693 fix waitid test under docker 1595b7d fix swap test under docker 321fdd2 Now an alpine package available 984b533 Add Dockerfile, fix some of the tests that made unreasonable assumptions 9aeff88 recent osx has *at functions 18cd829 better handling for xattr errors b6bb892 freebsd 11 now has utimensat 7065b0d on freebsd/zfs chflags will fail, skip git-subtree-dir: lib/ljsyscall git-subtree-split: e587f8c55aad3955dddab3a4fa6c1968037b5c6e

wingo reviewed Jan 26, 2016
View reviewed changes

kbara force-pushed the lwram_ndp branch from 386985a to 543052b Compare February 3, 2016 13:46

WIP. First end-to-end test passes.

2980458

kbara force-pushed the lwram_ndp branch from 543052b to 2980458 Compare February 4, 2016 10:31

kbara closed this Feb 4, 2016

kbara mentioned this pull request Feb 5, 2016

Renamed misleading pred variable to otherkey #226

Merged

kbara deleted the lwram_ndp branch September 29, 2016 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bLwram ndp #208

bLwram ndp #208

kbara commented Jan 26, 2016

wingo Jan 26, 2016

kbara Jan 26, 2016

wingo Jan 26, 2016

wingo commented Jan 26, 2016

kbara commented Jan 26, 2016

wingo commented Jan 26, 2016

kbara commented Jan 26, 2016

kbara commented Feb 4, 2016

wingo commented Feb 4, 2016

kbara commented Feb 4, 2016

wingo commented Feb 4, 2016

kbara commented Feb 4, 2016

bLwram ndp #208

bLwram ndp #208

Conversation

kbara commented Jan 26, 2016

wingo Jan 26, 2016

Choose a reason for hiding this comment

kbara Jan 26, 2016

Choose a reason for hiding this comment

wingo Jan 26, 2016

Choose a reason for hiding this comment

wingo commented Jan 26, 2016

kbara commented Jan 26, 2016

wingo commented Jan 26, 2016

kbara commented Jan 26, 2016

kbara commented Feb 4, 2016

wingo commented Feb 4, 2016

kbara commented Feb 4, 2016

wingo commented Feb 4, 2016

kbara commented Feb 4, 2016