Do not use timers to implement NS requests and retries #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why hasn't the test run completed? |
dpino
force-pushed
the
ndp-without-timers
branch
from
6f52068 to
f6d6bef
Compare
|
CI tests are passing now. I don't know what was the reason why the CI test were not automatically launched. If you see that happening, restart snabb_bot: $ sudo systemctl restart snabb_bot.service |
dpino
force-pushed
the
ndp-without-timers
branch
from
f6d6bef to
9e86b23
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #365