Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use saved passwords in private mode #1510

Closed
Dr-Battenburg opened this issue Aug 9, 2024 · 6 comments · Fixed by #1527
Closed

Can't use saved passwords in private mode #1510

Dr-Battenburg opened this issue Aug 9, 2024 · 6 comments · Fixed by #1527

Comments

@Dr-Battenburg
Copy link

Apologies if this has already been mentioned, I used the search function but didn't find anything.

When in private mode it doesn't auto-fill saved passwords into websites. Is there a way I can enable this? Most browsers do this automatically.

To be clear, I'm talking about passwords that have been saved in the browser while not in private mode.

Thanks.
@svillar
Copy link
Member

svillar commented Aug 12, 2024

I think this is how desktop browsers behave?

@Dr-Battenburg
Copy link
Author

I think this is how desktop browsers behave?

It's not. Not for Chrome or Firefox anyway. The key is that it has to be a login that's been saved while not in private mode.

svillar added a commit that referenced this issue Aug 30, 2024
@svillar
Show autocomplete select prompt if there is at least 1 login
006cfb4 
Login selection prompt was not shown if there was only 1 login
available under the assumption that in that case the web engine
will automatically fill in the saved data in the HTML form.

That's usually correct, however there is an scenario where it
does not happen. And that scenario is private browsing mode. In
that mode the login/pass is requested as usual, but it isn't
autofilled in the form until the user clicks on the login/pass
HTML input elements.

The consequence was that when in private browsing mode, for those
sites with only 1 password was saved (most common case) the
user/pass were not autofilled and the prompt dialog was not shown
giving the impression that no user/pass tuple was retrieved
from the logins storage.

Fixes #1510
@svillar
Copy link
Member

svillar commented Aug 30, 2024

I think this is how desktop browsers behave?

It's not. Not for Chrome or Firefox anyway. The key is that it has to be a login that's been saved while not in private mode.

So the key here is that Firefox does not autofill them in private browsing mode but it allows you to use the saved password if the user clicks on the user/pass entry fields. We'll do the same in Wolvic.

@svillar svillar mentioned this issue Aug 30, 2024
Merged
@Dr-Battenburg
Copy link
Author

Awesome, thank you! 👏

@svillar
Copy link
Member

svillar commented Aug 30, 2024

Let's keep it open, github will automatically close this once the patch lands

@svillar svillar reopened this Aug 30, 2024
@Dr-Battenburg
Copy link
Author

No problem, apologies I'm not that familiar with Github etiquette.

@svillar svillar closed this as completed in cc5a654 Sep 2, 2024
svillar added a commit that referenced this issue Sep 5, 2024
@svillar
Show autocomplete select prompt if there is at least 1 login
5bcde8d 
Login selection prompt was not shown if there was only 1 login
available under the assumption that in that case the web engine
will automatically fill in the saved data in the HTML form.

That's usually correct, however there is an scenario where it
does not happen. And that scenario is private browsing mode. In
that mode the login/pass is requested as usual, but it isn't
autofilled in the form until the user clicks on the login/pass
HTML input elements.

The consequence was that when in private browsing mode, for those
sites with only 1 password was saved (most common case) the
user/pass were not autofilled and the prompt dialog was not shown
giving the impression that no user/pass tuple was retrieved
from the logins storage.

Fixes #1510
felipeerias pushed a commit that referenced this issue Oct 21, 2024
@svillar @felipeerias
Show autocomplete select prompt if there is at least 1 login
6c4f1d0 
Login selection prompt was not shown if there was only 1 login
available under the assumption that in that case the web engine
will automatically fill in the saved data in the HTML form.

That's usually correct, however there is an scenario where it
does not happen. And that scenario is private browsing mode. In
that mode the login/pass is requested as usual, but it isn't
autofilled in the form until the user clicks on the login/pass
HTML input elements.

The consequence was that when in private browsing mode, for those
sites with only 1 password was saved (most common case) the
user/pass were not autofilled and the prompt dialog was not shown
giving the impression that no user/pass tuple was retrieved
from the logins storage.

Fixes #1510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show autocomplete select prompt if there is at least 1 login Igalia/wolvic
2 participants
@svillar @Dr-Battenburg