Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a webconfig for each of the web component product's endpoints. Ad… #21

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

MayaKirova
Copy link
Contributor

…d handling to use the related config base on option.

Depends on IgniteUI/typedoc-plugin-localization#75

Related to: IgniteUI/igniteui-webcomponents#991 (comment)

…d handling to use the related config base on option.
Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all webcomponents files should be named as follow:
---.dockmanager.config.json
---.licensed.config.json
---.oss.config.json
because there is a webpack config that looks for ---.config files when building

new CopyPlugin({
            patterns: [
                {
                    context: path.resolve(__dirname),
                    from: "*config.json",
                    to: path.resolve(__dirname, "dist"),
                },
            ],
        }),

Currently, the tree webcomponents configs are not coppied in the dist folder when built.

@mddragnev
Copy link
Member

Also, I have an error when trying to build the angular docs:
Screenshot 2024-01-05 at 17 12 45

It seems to be something around the reading of the produced filePath:

    const config = JSON.parse(fs.readFileSync(filePath, 'utf8'));

@MayaKirova MayaKirova requested a review from mddragnev January 5, 2024 15:38
@skrustev skrustev self-requested a review January 8, 2024 17:44
@dkamburov dkamburov requested a review from simeonoff January 9, 2024 09:08
@simeonoff simeonoff merged commit 4f625f9 into master Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants