Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update overlay attach dynamic component overload #11671

Closed
damyanpetev opened this issue Jun 3, 2022 · 4 comments · Fixed by #11685
Closed

Update overlay attach dynamic component overload #11671

damyanpetev opened this issue Jun 3, 2022 · 4 comments · Fixed by #11685
Assignees
@Lipata @damyanpetev @wnvko
Labels
overlay refactoring triage: blocking version: 15.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@damyanpetev
Copy link
Member

Since the ComponentFactory is deprecated and the new way of creating dynamic components in Angular is done through the viewContainerRef I think we should update our Overlay's attach with an overload that accepts a viewContainerRef. The current overload:

igniteui-angular/projects/igniteui-angular/src/lib/services/overlay/overlay.ts

Lines 321 to 322 in a7aebb0

public attach(component: Type<any>, settings?: OverlaySettings,
moduleRef?: Pick<NgModuleRef<any>, 'injector' | 'componentFactoryResolver'>): string;

Should be deprecated - the sooner the better, so we can have a transition period before the old API is dropped.
@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 6, 2022
wnvko added a commit that referenced this issue Jun 7, 2022
@wnvko
feat(overlay): use ViewContainerRef to create components, #11671
4ab4332
@wnvko wnvko mentioned this issue Jun 7, 2022
Merged
14 tasks
wnvko added a commit that referenced this issue Jun 8, 2022
@wnvko
test(overlay): fix failing tests, #11671
e99c85e
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 7, 2022
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Oct 8, 2022
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Oct 10, 2022
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Dec 10, 2022
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Dec 11, 2022
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Feb 10, 2023
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Feb 10, 2023
@ChronosSF ChronosSF added version: 15.1.x triage: blocking and removed version: 14.0.x 🛠️ status: in-development Issues and PRs with active development on them labels Mar 6, 2023
@ChronosSF ChronosSF added the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Mar 10, 2023
Lipata pushed a commit that referenced this issue Mar 14, 2023
@wnvko
feat(overlay): use ViewContainerRef to create components #11671 (#11685)
d072852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@damyanpetev damyanpetev

@wnvko wnvko

Labels
overlay refactoring triage: blocking version: 15.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ViewContainerRef to create components in overlay service IgniteUI/igniteui-angular
4 participants
@ChronosSF @Lipata @damyanpetev @wnvko