Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igxCombo API changes - value & selection #13089

Closed
Lipata opened this issue Jun 7, 2023 · 0 comments · Fixed by #13207
Closed

igxCombo API changes - value & selection #13089

Lipata opened this issue Jun 7, 2023 · 0 comments · Fixed by #13207
Assignees
Labels
🐛 bug Any issue that describes a bug combo version: 16.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Lipata
Copy link
Member

Lipata commented Jun 7, 2023

Description

  • igxCombo value should return an array of value keys instead of display keys
  • igxCombo selection should return an array of data items. Currently, it does it, when valueKey is not provided, but return array of value keys when the valueKey is provided, which should be done by the value property.
  • new displayValue that will return [] of display keys or CSV.
  • values in the events should be synced with igc-combo: Combo change event emits wrong value igniteui-webcomponents#796

Please check the latest API changes in the spec: https://github.com/IgniteUI/igniteui-angular/wiki/IgxCombo-(Component)

Please check the web-components combo spec and implementation in order to be in sync between 2 frameworks: https://github.com/IgniteUI/igniteui-webcomponents/wiki/%5BWIP%5D-Combo-Specification

Migrations will be needed.

  • igniteui-angular version: 16.x
@Lipata Lipata added 🐛 bug Any issue that describes a bug 🆕 status: new labels Jun 7, 2023
@Lipata Lipata self-assigned this Jun 7, 2023
@MonikaKirkova MonikaKirkova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 21, 2023
@MonikaKirkova MonikaKirkova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug combo version: 16.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants