Add displayValue and change selection and value #13207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosiah
added
the
🛠️ status: in-development
MonikaKirkova
added
❌ status: awaiting-test
RivaIvanova
added
💥 status: in-test
jackofdiamond5
previously approved these changes
Jul 20, 2023
| @@ -8,7 +8,7 @@ | |||
| <ng-container ngProjectAs="igx-hint, [igxHint]"> | |||
| <ng-content select="igx-hint, [igxHint]"></ng-content> | |||
| </ng-container> | |||
| <input igxInput #comboInput name="comboInput" type="text" [value]="value" readonly | |||
| <input igxInput #comboInput name="comboInput" type="text" [value]="displayValue.join(', ')" readonly | |||
There was a problem hiding this comment.
For future reference - we might want to expose a way for the users to define a custom separator for the values in the combo.
projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.ts
Outdated
Show resolved
Hide resolved
…into mkirkova/fix-13089
jackofdiamond5
approved these changes
Jul 25, 2023
desig9stein
pushed a commit
that referenced
this pull request
Jul 26, 2023
* feat(combo): add displayValue and change selection and value * chore(combo): add migrations and update CHANGELOG.md * chore(combo): add requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13089
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)