Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies between input and textarea #13255

Closed
SisIvanova opened this issue Jul 13, 2023 · 0 comments · Fixed by #13314, IgniteUI/igniteui-webcomponents#844, #13317 or #13318
Closed

Inconsistencies between input and textarea #13255

SisIvanova opened this issue Jul 13, 2023 · 0 comments · Fixed by #13314, IgniteUI/igniteui-webcomponents#844, #13317 or #13318
Assignees
Labels
🐛 bug Any issue that describes a bug input-group ✨ themes version: 15.1.x version: 16.0.x version: 16.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@SisIvanova
Copy link
Collaborator

Description

There are some differences between a regular input and a textarea related to the left and right indentations. For instance, in Indigo theme, an input prefix has a min-width of 12px, no padding between the prefix and the input text, and 12px padding between the input text and the suffix. The min-width and padding are not changing depending on the display density of the input. If a user changes the background of the prefix/suffix containers, the input text will have no padding on the left but only on the right.

Screenshot 2023-07-13 at 5 54 46 PM

The textarea, on the other hand, has not only 12px min-width on its prefix but also a padding-inline of 8px/6px/4px depending on the display density. This results in a different left and right indentation in the textarea itself if there is no prefix and suffix and also differs from a regular input field.

Screenshot 2023-07-13 at 5 59 51 PM
  • igniteui-angular version: 16.1.x / 16.0.x / 15.1.x

Similar problems are present in the rest of the themes. There may also be some issues in IgniteUI WebComponents.

Steps to reproduce

  1. Open the input group sample
  2. Compare the left and right indentations of a regular input and a textarea

Expected result

All input fields should be consistent.

@SisIvanova SisIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jul 24, 2023
@SisIvanova SisIvanova linked a pull request Jul 27, 2023 that will close this issue
14 tasks
@SisIvanova SisIvanova linked a pull request Jul 27, 2023 that will close this issue
14 tasks
@SisIvanova SisIvanova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 27, 2023
simeonoff pushed a commit that referenced this issue Aug 1, 2023
* fix(input): styling inconsistencies
Closes #13255
---------

Co-authored-by: Marin Popov <desig9stein@users.noreply.github.com>
simeonoff added a commit that referenced this issue Aug 1, 2023
* fix(input): styling inconsistencies
Closes #13255
---------

Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
simeonoff added a commit that referenced this issue Aug 1, 2023
* fix(input): styling inconsistencies
Closes #13255
---------

Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment