-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate date and time editing functionalities from igxDatePicker and igxTimePicker into a new directive #6271
Closed
38 of 42 tasks
Labels
🕐 time-picker
📅 date-picker
📅 date-time-editor
input
mask-editor
🧰 feature-request
version: 9.1.x
✅ status: resolved
Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Comments
This was referenced Dec 4, 2019
jackofdiamond5
added
🛠️ status: in-development
Issues and PRs with active development on them
and removed
🆕 status: new
labels
Dec 20, 2019
jackofdiamond5
changed the title
Separate date editing functionality from igxDatePicker into a new directive
Separate date and time editing functionalities from igxDatePicker and igxTimePicker into a new directive
Jan 13, 2020
This was referenced Jan 13, 2020
Closed
This was referenced Mar 9, 2020
jackofdiamond5
added a commit
that referenced
this issue
Mar 16, 2020
- ngModel binding - value spinning - min/max range - dev demo (initial) - Unit tests for spinning; isSpinLoop
jackofdiamond5
added a commit
that referenced
this issue
Mar 17, 2020
jackofdiamond5
added a commit
that referenced
this issue
Mar 17, 2020
14 tasks
jackofdiamond5
added
✅ status: resolved
Applies to issues that have pending PRs resolving them, or PRs that have already merged.
and removed
🛠️ status: in-development
Issues and PRs with active development on them
labels
Mar 18, 2020
jackofdiamond5
added a commit
that referenced
this issue
Mar 19, 2020
jackofdiamond5
added a commit
that referenced
this issue
Mar 20, 2020
jackofdiamond5
added a commit
that referenced
this issue
Mar 23, 2020
jackofdiamond5
added a commit
that referenced
this issue
Mar 27, 2020
jackofdiamond5
added a commit
that referenced
this issue
Mar 31, 2020
IvayloG
added a commit
that referenced
this issue
Mar 31, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 13, 2020
Lipata
added a commit
that referenced
this issue
Apr 14, 2020
Lipata
added a commit
that referenced
this issue
Apr 14, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 15, 2020
Lipata
added a commit
that referenced
this issue
Apr 15, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 15, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 15, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 15, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 16, 2020
jackofdiamond5
added a commit
that referenced
this issue
Apr 21, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 23, 2020
damyanpetev
added a commit
that referenced
this issue
Apr 27, 2020
PlamenaMiteva
added a commit
that referenced
this issue
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🕐 time-picker
📅 date-picker
📅 date-time-editor
input
mask-editor
🧰 feature-request
version: 9.1.x
✅ status: resolved
Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Is your feature request related to a problem? Please describe.
Right now there's a standalone Mask input, but no alternative for Date input.
Functionality for this exists inside the Date Picker, however it's not exposed. Further, this leads to re-templated pickers being stuck with reduced functionality (see Retemplated Dropdown Date Picker) and isn't reusable by other components (e.g. Date Range)
Looking at angular/angular#8203 we might want to look into supporting type "date" and "datetime-local"
Describe the solution you'd like
Ideally a directive that can handle Date (perhaps and time) input (extending from
igxMask
) and Model binding (ValueAccessor
), potentially supporting native date input types as well.Describe alternatives you've considered
See SO links below. Those don't look clean in API or always work well TBH.
Additional context
Date input is especially painful, since dates usually require formatting which means a separation of value and display text and there's definitely room for improvement here as seen in multiple SO questions:
https://stackoverflow.com/questions/37055311/angular2-how-to-use-javascript-date-object-with-ngmodel-two-way-binding
https://stackoverflow.com/questions/38175251/angular-2-date-input-not-binding-to-date-value
All of those deal with trying to format the Date as string and somehow parse it back with varying success.
The text was updated successfully, but these errors were encountered: