Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lastSearchInfo docs and unify interfaces with highlight directive- master #13286

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

onlyexeption
Copy link
Contributor

Closes #13051

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mtsvyatkova mtsvyatkova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 20, 2023
@kdinev kdinev merged commit d50cd5d into master Jul 24, 2023
@kdinev kdinev deleted the ibarakov/fix-13051-master branch July 24, 2023 08:19
@PooSham
Copy link

PooSham commented Aug 7, 2023

@onlyexeption @kdinev @mtsvyatkova @igdmdimitrov This caused breaking changes in a minor release btw. We used matchInfoCache in our codebase and it stopped working. IMO you should re-add the old property ASAP and make a new PR that removes it in the next major release (according to this versioning system: https://github.com/IgniteUI/igniteui-angular/wiki/Ignite-UI-for-Angular-versioning)

Here is the breaking change
https://github.com/IgniteUI/igniteui-angular/pull/13286/files#diff-6dab3c2a71241663629e36dd675fefcf1f36396d74c66adbb1d9d4c7251de75eL106

@kdinev
Copy link
Member

kdinev commented Aug 7, 2023

@PooSham I agree. @onlyexeption The breaking change was not checked in the checklist and I overlooked it during the review. Please add the property back in the 16.0.x branch and it can get removed in 16.1.x.

@kdinev
Copy link
Member

kdinev commented Aug 7, 2023

@onlyexeption Actually, the PR should be reverted in 16.0.x and documented as a breaking change for 16.1.x. Please also see if you can add automatic migration for it.

@ChronosSF
Copy link
Member

@onlyexeption @kdinev @mtsvyatkova @igdmdimitrov This caused breaking changes in a minor release btw. We used matchInfoCache in our codebase and it stopped working. IMO you should re-add the old property ASAP and make a new PR that removes it in the next major release (according to this versioning system: https://github.com/IgniteUI/igniteui-angular/wiki/Ignite-UI-for-Angular-versioning)

Here is the breaking change https://github.com/IgniteUI/igniteui-angular/pull/13286/files#diff-6dab3c2a71241663629e36dd675fefcf1f36396d74c66adbb1d9d4c7251de75eL106

@PooSham , 16.0.17 which was just released returns the matchInfoCache . We will probably revisit the API for 16.1 but it'll come with proper migrations. The change in a minor for 16.0 was not intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
text-highlight version: 16.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Angular Elements Grid] Grid's lastSearchInfo is undefined.
6 participants