refactor(progress-bar): refactor progress bars initial commit #15231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonoff
requested changes
Jan 14, 2025
projects/igniteui-angular/src/lib/core/styles/components/progress/circular/_circular-theme.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/components/progress/circular/_circular-theme.scss
Show resolved
Hide resolved
Comment on lines
+126
to
+145
| $bar-height: map.get(( | ||
| 'material': rem(4px), | ||
| 'fluent': rem(2px), | ||
| 'bootstrap': rem(16px), | ||
| 'indigo': rem(4px), | ||
| ), $variant); | ||
|
|
||
| $bar-height: map.get(( | ||
| 'material': rem(4px), | ||
| 'fluent': rem(2px), | ||
| 'bootstrap': rem(16px), | ||
| 'indigo': rem(4px), | ||
| ), $variant); | ||
|
|
||
| $strip-size: map.get(( | ||
| 'material': rem(16px), | ||
| 'fluent': rem(16px), | ||
| 'bootstrap': rem(5px), | ||
| 'indigo': rem(16px), | ||
| ), $variant); |
There was a problem hiding this comment.
Ideally, all of these should be listed as design tokens in the component schema. Let's defer this for now and add it to another task for when we refactor the token system in the theming library.
There was a problem hiding this comment.
I am adding a TODO so we don't forget about this
projects/igniteui-angular/src/lib/progressbar/circularbar.component.spec.ts
Outdated
Show resolved
Hide resolved
| expect(progress.max).toBe(defaultMaxValue); | ||
| expect(progress.value).toBe(0); | ||
| }); | ||
| function clasListContains(element: HTMLElement, className: string, expected: boolean) { |
There was a problem hiding this comment.
Suggested change
| function clasListContains(element: HTMLElement, className: string, expected: boolean) { | |
| function classListContains(element: HTMLElement, className: string, expected: boolean) { |
projects/igniteui-angular/src/lib/progressbar/linearbar.component.spec.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+29
to
+31
| function clasListContains(element: HTMLElement, className: string, expected: boolean) { | ||
| expect(element.classList.contains(className)).toBe(expected); | ||
| } |
There was a problem hiding this comment.
Suggested change
| function clasListContains(element: HTMLElement, className: string, expected: boolean) { | |
| expect(element.classList.contains(className)).toBe(expected); | |
| } | |
| function hasClass(element: HTMLElement, className: string, expected: boolean) { | |
| expect(element.classList.contains(className)).toBe(expected); | |
| } |
This function is declared both here and in the circular tests. Extract it into the helper-utils.spec.ts in the test-utils folder.
Comment on lines
+5
to
+7
| @Component({ | ||
| template: '', | ||
| }) |
There was a problem hiding this comment.
Suggested change
| @Component({ | |
| template: '', | |
| }) | |
| @Directive() |
| @Component({ | ||
| template: '', | ||
| }) | ||
| class TestProgressComponent extends BaseProgressDirective { |
There was a problem hiding this comment.
Suggested change
| class TestProgressComponent extends BaseProgressDirective { | |
| class TestProgressDirective extends BaseProgressDirective { |
| @@ -203,27 +196,48 @@ export abstract class BaseProgressDirective { | |||
| return this._max; | |||
| } | |||
|
|
|||
| @HostBinding('style') | |||
There was a problem hiding this comment.
This means that any style attribute the end-users apply to the progressbar component will be overridden by this method.
…ess/circular/_circular-theme.scss Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
…onent.spec.ts Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
…ent.spec.ts Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15162
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)