Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date/time picker: action buttons customization #4942

Merged
merged 21 commits into from
Jun 10, 2019
Merged

Date/time picker: action buttons customization #4942

merged 21 commits into from
Jun 10, 2019

Conversation

SAndreeva
Copy link
Contributor

@SAndreeva SAndreeva commented May 30, 2019 •
edited
Loading

Closes #4647

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@SAndreeva SAndreeva requested review from bkulov and sboykova May 30, 2019 15:22
@SAndreeva SAndreeva added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels May 31, 2019
@SAndreeva SAndreeva added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 31, 2019
@SAndreeva SAndreeva added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 3, 2019
bkulov
bkulov suggested changes Jun 6, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
bkulov
bkulov previously approved these changes Jun 6, 2019
View reviewed changes
damyanpetev
damyanpetev reviewed Jun 6, 2019
View reviewed changes
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts Show resolved Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
* An event that is emitted when the `IgxDatePickerComponent` is being closed.
*/
@Output()
public onClosing = new EventEmitter<CancelableBrowserEventArgs>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So onClosing but no onOpening? Not sure if there's need for that, other than canceling, but have to ask.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we don't need onOpening event because there's nothing to be customized by the user when the date picker is opening.

projects/igniteui-angular/src/lib/date-picker/date-picker.directives.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts Outdated Show resolved Hide resolved
@sboykova sboykova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 6, 2019
SAndreeva pushed a commit that referenced this pull request Jun 7, 2019
@sboykova @SAndreeva
fix(time-picker): Fixed failing test #4942
5c6e7cd
bkulov
bkulov previously approved these changes Jun 7, 2019
View reviewed changes
@sboykova sboykova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 7, 2019
@bkulov bkulov merged commit a2cf288 into 7.3.x Jun 10, 2019
@bkulov bkulov deleted the SAndreeva/pickers-custom-buttons branch June 10, 2019 06:40
bkulov pushed a commit that referenced this pull request Jun 11, 2019
@SAndreeva @bkulov
Date/time picker: action buttons customization - master (#5027)
763dea9 
* feat(pickers): custom buttons functionality #4647

* chore(*): fix lint errors #4647

* chore(*): remove trailing white space #4647

* feat(pickers): add custom styling ability #4647

* feat(pickers): remove css and unify retemplating approach #4647

* chore(*): update README.md and CHANGELOG.md #4647

* chore(*): address some review comments #4647

# Conflicts:
#	CHANGELOG.md

* chore(*): more code improvements #4647

* fix(time-picker): Fixed failing test #4942

* chore(*): update code snippet in README.md #4647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev left review comments

@bkulov bkulov bkulov approved these changes

@sboykova sboykova sboykova approved these changes

Assignees

@sboykova sboykova

Labels
🕐 time-picker 📅 date-picker version: 7.3.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SAndreeva @bkulov @damyanpetev @sboykova