feat(grid): expose column input for template context #9694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobromirts
added
❌ status: awaiting-test
hanastasov
previously approved these changes
Jun 10, 2021
zdrawku
added
💥 status: in-test
zdrawku
added
✅ status: verified
rkaraivanov
requested changes
Jun 28, 2021
Comment on lines
932
to
933
| public set templateContext(value: any){ | ||
| this._contextObject = value; |
There was a problem hiding this comment.
-
templateContextsuggests that the use can overwrite the context object in the column templates making it a little dubious.
MaybeadditionalTemplateContextor something along these lines. -
I don't think you need to separate it between a setter and a getter. Just leave it as simple property on the class.
-
It will be nice to access the additional context directly from the template binding:
<ng-template igxCell let-props="additionalContext">
...
</ng-template>
hanastasov
approved these changes
Jun 30, 2021
rkaraivanov
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9020
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)