Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown discrepancies in Material, Bootstrap and Fluent themes #1405

Closed
didimmova opened this issue Sep 26, 2024 · 0 comments · Fixed by #1409 or IgniteUI/igniteui-theming#340
Closed
Assignees
Labels
bug Something isn't working drop-down

Comments

@didimmova
Copy link
Contributor

didimmova commented Sep 26, 2024

Which component(s) are affected?

Dropdown

Description

The dropdown layout styles are not the same as they're in the UI kits. The problems are in every theme, except for Indigo.

-The size of the items and header in all themes, except for Indigo should be 28/32/40 for small, medium and large.
-The margin of the prefix and suffix should be 8px, not 16px.
-The inline paddings for the items should be 16/20/24 for small, medium and large.
-The inline paddings for the header should be 8/12/16 for small, medium and large.
-The slotted icon in Fluent should be 24px for all sizes

Reproduction

  1. Open the Storybook
  2. Open the Dropdown sample
  3. Inspect the layout of the items in all themes, changing the --ig-size to small, medium and large

Workaround

The implementation should be aligned with the UI kits

Is this a regression?

No or unsure. This never worker, or I haven't tried before.

Affected versions

5.0.1

Browser/OS/Node environment

All

@didimmova didimmova added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. drop-down labels Sep 26, 2024
@didimmova didimmova changed the title Dropdown discrepancies Dropdown discrepancies in Material, Bootstrap and Fluent themes Sep 26, 2024
@simeonoff simeonoff assigned didimmova and unassigned simeonoff Sep 27, 2024
@simeonoff simeonoff removed the 🆕 status: new The issue is new and will be reviewed when somebody picks it up. label Sep 27, 2024
@didimmova didimmova linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working drop-down
Projects
None yet
2 participants