Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combo items height #1407

Closed
didimmova opened this issue Sep 26, 2024 · 1 comment · Fixed by #1409
Closed

Combo items height #1407

didimmova opened this issue Sep 26, 2024 · 1 comment · Fixed by #1409
Assignees
@didimmova
Labels
bug Something isn't working combo

Comments

@didimmova
Copy link
Contributor

Which component(s) are affected?

Combo

Description

The combo items in Material, Bootstrap and Fluent themes should be 28px, 32px, 40px for small, medium and large sizes.

Reproduction

  1. Open Storybook App
  2. Open Combo Sample
  3. Explore different themes and sizes

Workaround

The sizes in the implementation should be aligned with the dropdown item sizes.

Is this a regression?

No or unsure. This never worker, or I haven't tried before.

Affected versions

5.0.1

Browser/OS/Node environment

all
@didimmova didimmova added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. combo labels Sep 26, 2024
@simeonoff simeonoff assigned didimmova and unassigned simeonoff Sep 26, 2024
@didimmova
Copy link
Contributor Author

This will be fixed with this issue

@didimmova didimmova mentioned this issue Sep 27, 2024
Merged
@simeonoff simeonoff removed the 🆕 status: new The issue is new and will be reviewed when somebody picks it up. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@didimmova didimmova

Labels
bug Something isn't working combo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(dropdown): update items sizes and paddings IgniteUI/igniteui-webcomponents
2 participants
@simeonoff @didimmova