Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Combo): Add support for groupingDirection: none .Remove the sorting of the items when combo has grouping. #1026

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

mddragnev
Copy link
Member

Closing #1017

Remove the sorting of the items when combo has
grouping.
Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/**
* Sorts the items in each group by ascending or descending order.
* @attr group-sorting
* @type {"asc" | "desc"}
*/
@property({ attribute: 'group-sorting', reflect: false })
public groupSorting: GroupingDirection = 'asc';

Make sure to add the new member of the groupSorting union.

/**
   * Sorts the items in each group by ascending or descending order.
   * @attr group-sorting
   * @type {"asc" | "desc" | "none"}
   */
  @property({ attribute: 'group-sorting', reflect: false })
  public groupSorting: GroupingDirection = 'asc';

src/components/combo/operations/group.ts Outdated Show resolved Hide resolved
@mddragnev mddragnev requested a review from rkaraivanov January 16, 2024 13:22
@rkaraivanov rkaraivanov merged commit 0fd1b3d into master Jan 16, 2024
5 checks passed
@rkaraivanov rkaraivanov deleted the mdragnev/feat-1017 branch January 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sorting of combo groups for group labels and records
3 participants